Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Bernd Edlinger
On 8/10/21 10:56 PM, Eric Botcazou wrote: >> Ah, thanks, I tried it but the defs__struct1IP function has >> DECL_IGNORED_P = false when I build it with -gnatD. >> >> So that would not be affected by setting DECL_SOURCE_LOCATION to >> UNKNOWN_LOCATION as done in the proposed patch, because that is o

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Eric Botcazou
> Ah, thanks, I tried it but the defs__struct1IP function has > DECL_IGNORED_P = false when I build it with -gnatD. > > So that would not be affected by setting DECL_SOURCE_LOCATION to > UNKNOWN_LOCATION as done in the proposed patch, because that is only > done for functions with DECL_IGNORED_P =

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Eric Botcazou
> ISTR it was changed because at least with location info generated > by gas there's no way to have "no location" for a portion of code. > Instead the assigned location will be that of the previous .loc > directive which results in random and confusing results for the > pc range of the DECL_INGORED

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Bernd Edlinger
On 8/9/21 4:37 PM, Eric Botcazou wrote: >> But it is okay that we can set a breakpoint on defs__struct1IP, >> in the test case of PR 101598. >> And the debugger shall only show assembler here. >> Right? > > The defs__struct1IP procedure should be totally transparent for the user, so > setting a b

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-10 Thread Richard Biener via Gcc-patches
On Mon, 9 Aug 2021, Eric Botcazou wrote: > > But it is okay that we can set a breakpoint on defs__struct1IP, > > in the test case of PR 101598. > > And the debugger shall only show assembler here. > > Right? > > The defs__struct1IP procedure should be totally transparent for the user, so > setti

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-09 Thread Eric Botcazou
> But it is okay that we can set a breakpoint on defs__struct1IP, > in the test case of PR 101598. > And the debugger shall only show assembler here. > Right? The defs__struct1IP procedure should be totally transparent for the user, so setting a breakpoint in it is not supposed to come into play.

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-04 Thread Bernd Edlinger
On 8/4/21 4:33 PM, Eric Botcazou wrote: >> The location of these ignored Ada decls looks completely sane to me. >> However, it was an unintentional side effect of the patch to allow >> minimal debugging of ignored decls. This means we can now step into >> those functions or set line breakpoints th

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-04 Thread Eric Botcazou
> The location of these ignored Ada decls looks completely sane to me. > However, it was an unintentional side effect of the patch to allow > minimal debugging of ignored decls. This means we can now step into > those functions or set line breakpoints there, while previously that > was not possibl

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-02 Thread Bernd Edlinger
On 8/2/21 3:07 PM, Eric Botcazou wrote: >> It was pointed out in PR101598 to be inappropriate, that >> ignored Ada decls receive the source line number which was >> recorded in the function decl's DECL_SOURCE_LOCATION. >> Therefore set all front-end-generated Ada decls with >> DECL_IGNORED_P to UNK

Re: [PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-08-02 Thread Eric Botcazou
> It was pointed out in PR101598 to be inappropriate, that > ignored Ada decls receive the source line number which was > recorded in the function decl's DECL_SOURCE_LOCATION. > Therefore set all front-end-generated Ada decls with > DECL_IGNORED_P to UNKNOWN_LOCATION. > > 2021-07-24 Bernd Edlinge

[PATCH 2/2] Ada: Remove debug line number for DECL_IGNORED_P functions

2021-07-26 Thread Bernd Edlinger
It was pointed out in PR101598 to be inappropriate, that ignored Ada decls receive the source line number which was recorded in the function decl's DECL_SOURCE_LOCATION. Therefore set all front-end-generated Ada decls with DECL_IGNORED_P to UNKNOWN_LOCATION. 2021-07-24 Bernd Edlinger P