Re: [PATCH 2/2] S/390: Do not end groups after fallthru edge

2017-10-18 Thread Robin Dapp
> Preserving the sched state across basic blocks for your case works only if > the BBs are traversed > with the fall through edges coming first. Is that the case? We probably > should have a description > for s390_last_sched_state stating this. Committed as attached with an additional comment an

Re: [PATCH 2/2] S/390: Do not end groups after fallthru edge

2017-10-17 Thread Robin Dapp
> Can't we just set s390_sched_state to s390_last_sched_state in > s390_sched_init. Good idea, this simplifies the code quite a bit. > Preserving the sched state across basic blocks for your case works > only if the BBs are traversed with the fall through edges coming > first. Is that the case? W

Re: [PATCH 2/2] S/390: Do not end groups after fallthru edge

2017-10-16 Thread Andreas Krebbel
On 10/11/2017 01:53 PM, Robin Dapp wrote: > This patch fixes cases where we start a new group although the previous one > has > not ended. > > Regression tested on s390x. > > gcc/ChangeLog: > > 2017-10-11 Robin Dapp > > * config/s390/s390.c (s390_has_ok_fallthru): New function. >

[PATCH 2/2] S/390: Do not end groups after fallthru edge

2017-10-11 Thread Robin Dapp
This patch fixes cases where we start a new group although the previous one has not ended. Regression tested on s390x. gcc/ChangeLog: 2017-10-11 Robin Dapp * config/s390/s390.c (s390_has_ok_fallthru): New function. (s390_sched_score): Temporarily change s390_sched_state.