[PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-14 Thread Maciej W. Rozycki
Unrecognized `gnatmake' switches are not implicitly passed on to the linker, so just pasting board `ldflags' and any other linker flags verbatim into `add_flags' to use for the invocation line of `gnatmake' will make them ignored at best. For example in a GCC test environment that has: set_boa

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-15 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: Unrecognized `gnatmake' switches are not implicitly passed on to the linker, so just pasting board `ldflags' and any other linker flags verbatim into `add_flags' to use for the invocation line of `gnatmake' will make them ignored at best. [...] For `gnatmake' to pass

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Maciej W. Rozycki
On Wed, 15 May 2019, Jacob Bachmeyer wrote: > This patch really exposes a significant deficiency in our current > implementation of default_target_compile: the order of various flags > can be significant, but we only have that order implicitly expressed in > the code, which goes all the way ba

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-16 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Wed, 15 May 2019, Jacob Bachmeyer wrote: This patch really exposes a significant deficiency in our current implementation of default_target_compile: the order of various flags can be significant, but we only have that order implicitly expressed in the code, whic

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-21 Thread Maciej Rozycki
On Thu, 16 May 2019, Jacob Bachmeyer wrote: > > I suspect the origins may be different, however as valuable as your > > observation is functional problems have precedence over issues with code > > structuring, so we need to fix the problem at hand first. I'm sure > > DejaGNU maintainers will

Re: [PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-05-21 Thread Jacob Bachmeyer
Maciej Rozycki wrote: On Thu, 16 May 2019, Jacob Bachmeyer wrote: I suspect the origins may be different, however as valuable as your observation is functional problems have precedence over issues with code structuring, so we need to fix the problem at hand first. I'm sure DejaGNU mainta

[PING^3][PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-10-25 Thread Maciej W. Rozycki
On Tue, 21 May 2019, Jacob Bachmeyer wrote: > > IOW I don't discourage you from developing a comprehensive solution, > > however applying my proposal right away will help at least some people and > > will not block you in any way. > > > > Correct, although, considering how long my FSF paper

Re: [PING^3][PATCH 3/3][DejaGNU] target: Wrap linker flags into `-largs'/`-margs' for Ada

2019-10-25 Thread Jacob Bachmeyer
Maciej W. Rozycki wrote: On Tue, 21 May 2019, Jacob Bachmeyer wrote: IOW I don't discourage you from developing a comprehensive solution, however applying my proposal right away will help at least some people and will not block you in any way. Correct, although, considering how lo