[PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-03-21 Thread Chung-Lin Tang
Hi Martin, I think you're the one to CC for this, as I mentioned in the first email, this has been build tested, however I did not know if I could test this without a Radeon card. If convenient, could you or anyone familiar with the setup do a make check-target-libgomp with this patch series? Tha

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-03-24 Thread Martin Jambor
Hi, On Mon, Mar 21, 2016 at 06:22:17PM +0800, Chung-Lin Tang wrote: > Hi Martin, I think you're the one to CC for this, > as I mentioned in the first email, this has been build tested, however I did > not know if I could test this without a Radeon card. If convenient, > could you or anyone famili

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-03-27 Thread Chung-Lin Tang
On 2016/3/25 上午 02:40, Martin Jambor wrote: > On the whole, I am fine with the patch but there are two issues: > > First, and generally, when you change the return type of a function, > you must document what return values mean in the comment of the > function. Most importantly, it must be immedi

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-03-29 Thread Martin Jambor
Hi, On Sun, Mar 27, 2016 at 06:26:29PM +0800, Chung-Lin Tang wrote: > On 2016/3/25 上午 02:40, Martin Jambor wrote: > > On the whole, I am fine with the patch but there are two issues: > > > > First, and generally, when you change the return type of a function, > > you must document what return val

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-04-16 Thread Chung-Lin Tang
On 2016/3/29 09:35 PM, Martin Jambor wrote: > Hi, > > On Sun, Mar 27, 2016 at 06:26:29PM +0800, Chung-Lin Tang wrote: >> On 2016/3/25 上午 02:40, Martin Jambor wrote: >>> On the whole, I am fine with the patch but there are two issues: >>> >>> First, and generally, when you change the return type of

Re: [PATCH 3/4, libgomp] Resolve deadlock on plugin exit, HSA plugin parts

2016-04-18 Thread Martin Jambor
Hi, On Sat, Apr 16, 2016 at 03:38:57PM +0800, Chung-Lin Tang wrote: > Hi Martin, the attached patch reverts that queue_callback() change, and adds > some more descriptions in the comments to reflect the bool return changes. > Please see if they are acceptable. > If the rest of the patch-set is a