On Mon, Nov 20, 2023 at 11:58 AM Björn Schäpers wrote:
>
> An updated version, using neither A or W, but just the macro.
Thanks. Committed as follows.
Ian
1017495bc91d40570f58c37e88ca013164782129
diff --git a/libbacktrace/pecoff.c b/libbacktrace/pecoff.c
index 56af4828e27..f976a963bf3 100644
在 2023/11/22 03:35, Björn Schäpers 写道:
I'll guess it is not needed here, but otherwise defines the macros max and min, they
then conflict e.g. with C++'s std::max/std::min. So I consider it best practice to always define it,
before including .
The mingw-w64 header does not define them for
I'll guess it is not needed here, but otherwise defines the macros
max and min, they then conflict e.g. with C++'s std::max/std::min. So I consider
it best practice to always define it, before including .
Am 20.11.2023 um 21:07 schrieb Eli Zaretskii:
Date: Mon, 20 Nov 2023 20:57:38 +0100
Cc:
> Date: Mon, 20 Nov 2023 20:57:38 +0100
> Cc: gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> From: Björn Schäpers
>
> +#ifndef NOMINMAX
> +#define NOMINMAX
> +#endif
Why is this part needed?
Otherwise, LGTM, thanks. (But I'm don't have the approval rights, so
please wait for Ian to chime in.)
An updated version, using neither A or W, but just the macro.
Am 21.01.2023 um 12:42 schrieb Eli Zaretskii:
Date: Sat, 21 Jan 2023 11:47:42 +0100
Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
From: Gabriel Ravier
On 1/21/23 05:05, Eli Zaretskii wrote:
Date: Fri, 20 Jan 2023
> Date: Sat, 21 Jan 2023 11:47:42 +0100
> Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> From: Gabriel Ravier
>
>
> On 1/21/23 05:05, Eli Zaretskii wrote:
> >> Date: Fri, 20 Jan 2023 21:39:56 +0100
> >> Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> >> From:
On 1/21/23 05:05, Eli Zaretskii wrote:
Date: Fri, 20 Jan 2023 21:39:56 +0100
Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
From: Gabriel Ravier
- using wide APIs with Windows is generally considered to be a best
practice, even when not strictly needed (and in this case I
> Date: Sat, 21 Jan 2023 17:18:14 +0800
> Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> From: LIU Hao
>
> 在 2023-01-21 12:05, Eli Zaretskii via Gcc 写道:
> > I'm not sure I follow the logic. A program that calls
> > GetModuleHandleW will refuse to start on Windows that doesn't
在 2023-01-21 12:05, Eli Zaretskii via Gcc 写道:
I'm not sure I follow the logic. A program that calls
GetModuleHandleW will refuse to start on Windows that doesn't have
that API. So any version before XP is automatically excluded the
moment you use code which calls that API directly (i.e. not
> Date: Fri, 20 Jan 2023 21:39:56 +0100
> Cc: g...@hazardy.de, gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> From: Gabriel Ravier
>
> >> - using wide APIs with Windows is generally considered to be a best
> >> practice, even when not strictly needed (and in this case I can't see
> >> any problem
On 1/20/23 20:19, Eli Zaretskii wrote:
Date: Fri, 20 Jan 2023 17:46:59 +0100
Cc: gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
From: Gabriel Ravier
On 1/20/23 14:39, Eli Zaretskii via Gcc wrote:
From: Björn Schäpers
Date: Fri, 20 Jan 2023 11:54:08 +0100
@@ -856,7 +870,12 @@ coff_add (struct
> Date: Fri, 20 Jan 2023 17:46:59 +0100
> Cc: gcc-patches@gcc.gnu.org, g...@gcc.gnu.org
> From: Gabriel Ravier
>
> On 1/20/23 14:39, Eli Zaretskii via Gcc wrote:
> >> From: Björn Schäpers
> >> Date: Fri, 20 Jan 2023 11:54:08 +0100
> >>
> >> @@ -856,7 +870,12 @@ coff_add (struct backtrace_state
On 1/20/23 14:39, Eli Zaretskii via Gcc wrote:
From: Björn Schäpers
Date: Fri, 20 Jan 2023 11:54:08 +0100
@@ -856,7 +870,12 @@ coff_add (struct backtrace_state *state, int descriptor,
+ (sections[i].offset - min_offset));
}
- if (!backtrace_dwarf_add
> From: Björn Schäpers
> Date: Fri, 20 Jan 2023 11:54:08 +0100
>
> @@ -856,7 +870,12 @@ coff_add (struct backtrace_state *state, int descriptor,
> + (sections[i].offset - min_offset));
> }
>
> - if (!backtrace_dwarf_add (state, /* base_address */ 0,
From: Björn Schäpers
Any underflow which might happen, will be countered by an overflow in
dwarf.c.
Tested on x86_64-linux and i686-w64-mingw32.
-- >8 --
Fixes https://github.com/ianlancetaylor/libbacktrace/issues/89 and
https://github.com/ianlancetaylor/libbacktrace/issues/82.
*
From: Björn Schäpers
Any underflow which might happen, will be countered by an overflow in
dwarf.c.
Tested on x86_64-linux and i686-w64-mingw32.
-- >8 --
Fixes https://github.com/ianlancetaylor/libbacktrace/issues/89 and
https://github.com/ianlancetaylor/libbacktrace/issues/82.
*
16 matches
Mail list logo
