Re: [PATCH 3/5] introduce the binding oracle

2014-06-19 Thread Tom Tromey
Jeff> Just a nit. C-style comment would be appreciated. It might also help Jeff> to clarify what "much more sane" really means here. Jeff> Otherwise, it looks OK to me. Here's the updated patch. Tom 2014-06-19 Phil Muldoon Tom Tromey * c-tree.h (enum c_oracle_request

Re: [PATCH 3/5] introduce the binding oracle

2014-06-05 Thread Tom Tromey
> "Jeff" == Jeff Law writes: Jeff> Just a nit. C-style comment would be appreciated. It might also help Jeff> to clarify what "much more sane" really means here. I made this change locally. The new comment reads: /* Temporarily hide any binding oracle. Without this, calls to debug

Re: [PATCH 3/5] introduce the binding oracle

2014-05-16 Thread Jeff Law
On 05/16/14 09:26, Tom Tromey wrote: gdb wants to supply any declarations that may be referred to by the user's code. Hooking into symbol lookup was an efficient way to accomplish this. This patch introducing a "binding oracle" that is consulted whenever a symbol binding is looked up for the fi

[PATCH 3/5] introduce the binding oracle

2014-05-16 Thread Tom Tromey
gdb wants to supply any declarations that may be referred to by the user's code. Hooking into symbol lookup was an efficient way to accomplish this. This patch introducing a "binding oracle" that is consulted whenever a symbol binding is looked up for the first time. The oracle is just a global