Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-31 Thread Richard Biener via Gcc-patches
On Thu, Aug 27, 2020 at 8:27 PM Giuliano Belinassi wrote: > > Hi, Honza. > > Thank you for your detailed review! > > On 08/27, Jan Hubicka wrote: > > > diff --git a/gcc/cgraph.c b/gcc/cgraph.c > > > index c0b45795059..22405098dc5 100644 > > > --- a/gcc/cgraph.c > > > +++ b/gcc/cgraph.c > > > @@ -2

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-29 Thread Jan Hubicka
> Hi, Honza. > > Thank you for your detailed review! > > On 08/27, Jan Hubicka wrote: > > > diff --git a/gcc/cgraph.c b/gcc/cgraph.c > > > index c0b45795059..22405098dc5 100644 > > > --- a/gcc/cgraph.c > > > +++ b/gcc/cgraph.c > > > @@ -226,6 +226,22 @@ cgraph_node::delete_function_version_by_dec

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-27 Thread Giuliano Belinassi via Gcc-patches
Hi, Honza. Thank you for your detailed review! On 08/27, Jan Hubicka wrote: > > diff --git a/gcc/cgraph.c b/gcc/cgraph.c > > index c0b45795059..22405098dc5 100644 > > --- a/gcc/cgraph.c > > +++ b/gcc/cgraph.c > > @@ -226,6 +226,22 @@ cgraph_node::delete_function_version_by_decl (tree > > decl) >

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-27 Thread Jan Hubicka
> diff --git a/gcc/cgraph.c b/gcc/cgraph.c > index c0b45795059..22405098dc5 100644 > --- a/gcc/cgraph.c > +++ b/gcc/cgraph.c > @@ -226,6 +226,22 @@ cgraph_node::delete_function_version_by_decl (tree decl) >decl_node->remove (); > } > > +/* Release function dominator info if present. */ > +

Re: [PATCH 3/6] Implement fork-based parallelism engine

2020-08-27 Thread Jan Hubicka
> We also implemented a GNU Make Jobserver integration to this mechanism, > as implemented in jobserver.cc. This works as follows: > diff --git a/gcc/jobserver.cc b/gcc/jobserver.cc > new file mode 100644 > index 000..8cb374de86e > --- /dev/null > +++ b/gcc/jobserver.cc I wonder if this ca

[PATCH 3/6] Implement fork-based parallelism engine

2020-08-20 Thread Giuliano Belinassi via Gcc-patches
This patch belongs to the "Parallelize GCC with Processes" series. Here, we implement the parallelism by forking the compiler into multiple processes after what would be the LTO LTRANS stage, partitioning the callgraph into several partitions, as implemented in "maybe_compile_in_parallel". From a