Re: [PATCH 3/7] Fix trinary op

2015-07-12 Thread Mikhail Maltsev
On 07/10/2015 11:44 PM, Jeff Law wrote: OK after regression testing. jeff Bootstrapped and regtested on x86_64-unknown-linux-gnu. Applied as r225727. -- Regards, Mikhail Maltsev

Re: [PATCH 3/7] Fix trinary op

2015-07-10 Thread Jeff Law
On 07/09/2015 10:48 PM, Mikhail Maltsev wrote: On 08.07.2015 13:55, Ian Lance Taylor wrote: I don't know of anybody who actually uses the DMGL_TYPES support. I don't know why anybody would. Ian Thanks for pointing that out. I updated the testcases, so that now they don't depend on DMGL_TYPES

Re: [PATCH 3/7] Fix trinary op

2015-07-09 Thread Mikhail Maltsev
On 08.07.2015 13:55, Ian Lance Taylor wrote: I don't know of anybody who actually uses the DMGL_TYPES support. I don't know why anybody would. Ian Thanks for pointing that out. I updated the testcases, so that now they don't depend on DMGL_TYPES being used. But better still is to consider

Re: [PATCH 3/7] Fix trinary op

2015-07-08 Thread Ian Lance Taylor
On Tue, Jul 7, 2015 at 3:40 PM, Jeff Law l...@redhat.com wrote: And a generic question on the testsuite -- presumably it turns on type demangling?I wanted to verify the flow through d_expression_1 was what I expected it to be and it took a while to realize that c++filt doesn't demangle

Re: [PATCH 3/7] Fix trinary op

2015-07-08 Thread Tom Tromey
Ian == Ian Lance Taylor i...@google.com writes: Ian I don't know of anybody who actually uses the DMGL_TYPES support. I Ian don't know why anybody would. It's used in gdb's DWARF reader, though I no longer remember why. Tom

Re: [PATCH 3/7] Fix trinary op

2015-07-08 Thread Ian Lance Taylor
On Wed, Jul 8, 2015 at 6:42 AM, Tom Tromey t...@tromey.com wrote: Ian == Ian Lance Taylor i...@google.com writes: Ian I don't know of anybody who actually uses the DMGL_TYPES support. I Ian don't know why anybody would. It's used in gdb's DWARF reader, though I no longer remember why.

Re: [PATCH 3/7] Fix trinary op

2015-07-07 Thread Jeff Law
On 07/06/2015 01:34 PM, Mikhail Maltsev wrote: --- libiberty/cp-demangle.c | 4 +++- libiberty/testsuite/demangle-expected | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 12093cc..44a0a9b 100644

[PATCH 3/7] Fix trinary op

2015-07-06 Thread Mikhail Maltsev
--- libiberty/cp-demangle.c | 4 +++- libiberty/testsuite/demangle-expected | 6 ++ 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libiberty/cp-demangle.c b/libiberty/cp-demangle.c index 12093cc..44a0a9b 100644 --- a/libiberty/cp-demangle.c +++