Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Andreas Schwab
Trevor Saunders tbsau...@tbsaunde.org writes: actually pointing out libojc/encoding.c was more useful since that makes it pretty clear the ifndef PCC_BITFIELD_TYPE_MATTERS there just needs to be changed to #if ! That probably won't work on arm or powerpc or vax: gcc/config/arm/arm.h:#define

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Andreas Schwab
Trevor Saunders tbsau...@tbsaunde.org writes: diff --git a/libobjc/encoding.c b/libobjc/encoding.c index 7333908..20ace46 100644 --- a/libobjc/encoding.c +++ b/libobjc/encoding.c @@ -1167,7 +1167,7 @@ objc_layout_structure_next_member (struct objc_struct_layout *layout) /* Record must

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 02:33:44PM +0200, Jakub Jelinek wrote: On Thu, Apr 30, 2015 at 08:25:14AM -0400, Trevor Saunders wrote: On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: actually pointing out libojc/encoding.c was

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 08:54:05AM +0200, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: diff --git a/libobjc/encoding.c b/libobjc/encoding.c index 7333908..20ace46 100644 --- a/libobjc/encoding.c +++ b/libobjc/encoding.c @@ -1167,7 +1167,7 @@

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Andreas Schwab
Trevor Saunders tbsau...@tbsaunde.org writes: I think true is a defined identifier since this is compiled as c11. tbsaunde@iceball:/src/gcc1-opt$ cat test.c #define FOO true #if !FOO hello #endif tbsaunde@iceball:/src/gcc1-opt$ gcc/xgcc -B gcc/ -E test.c # 1 test.c # 1 built-in # 1

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Jakub Jelinek
On Thu, Apr 30, 2015 at 07:58:33AM -0400, Trevor Saunders wrote: On Thu, Apr 30, 2015 at 08:54:05AM +0200, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: diff --git a/libobjc/encoding.c b/libobjc/encoding.c index 7333908..20ace46 100644 --- a/libobjc/encoding.c

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Jakub Jelinek
On Thu, Apr 30, 2015 at 08:25:14AM -0400, Trevor Saunders wrote: On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: actually pointing out libojc/encoding.c was more useful since that makes it pretty clear the ifndef

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 08:40:50AM +0200, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: actually pointing out libojc/encoding.c was more useful since that makes it pretty clear the ifndef PCC_BITFIELD_TYPE_MATTERS there just needs to be changed to #if ! That

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Joseph Myers
On Thu, 30 Apr 2015, Jakub Jelinek wrote: I guess the best thing to do is justadd a __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? I think adding way too many predefines, especially rarely used ones, is harmful, certainly it isn't free, consider -g3 or -dD where

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-30 Thread Trevor Saunders
On Thu, Apr 30, 2015 at 05:41:57PM +, Joseph Myers wrote: On Thu, 30 Apr 2015, Jakub Jelinek wrote: I guess the best thing to do is justadd a __PCC_BITFIELD_TYPE_MATTERS__ that gcc defines and use that in libobjc? I think adding way too many predefines, especially rarely used

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
spawn /daten/aranym/gcc/gcc-20150429/Build/gcc/xgcc -B/daten/aranym/gcc/gcc-20150429/Build/gcc/ /daten/aranym/gcc/gcc-20150429/gcc/testsuite/objc/execute/bf-1.m -fno-diagnostics-show-caret -fdiagnostics-color=never -w -O0 -fgnu-runtime

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Andreas Schwab
Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See libobjc/encoding.c. Andreas. -- Andreas Schwab, sch...@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 02:35:39PM +0200, Andreas Schwab wrote: spawn /daten/aranym/gcc/gcc-20150429/Build/gcc/xgcc -B/daten/aranym/gcc/gcc-20150429/Build/gcc/ /daten/aranym/gcc/gcc-20150429/gcc/testsuite/objc/execute/bf-1.m -fno-diagnostics-show-caret -fdiagnostics-color=never -w -O0

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See libobjc/encoding.c. Can't you just answer the question Andreas instead of

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with #undef PCC_BITFIELD_TYPE_MATTERS. See

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux after that commit, what platform is this? Any one with

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 04:29:26PM -0600, Jeff Law wrote: On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders tbsau...@tbsaunde.org writes: it passes for me on x86_64-linux

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Trevor Saunders
On Wed, Apr 29, 2015 at 08:13:16PM -0400, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:29:26PM -0600, Jeff Law wrote: On 04/29/2015 04:25 PM, Trevor Saunders wrote: On Wed, Apr 29, 2015 at 04:00:47PM -0600, Jeff Law wrote: On 04/29/2015 03:55 PM, Andreas Schwab wrote: Trevor Saunders

Re: [PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-29 Thread Jeff Law
On 04/29/2015 08:10 PM, Trevor Saunders wrote: I decided to commit this, it seems like testing it can be slow on some targets and I did a bootstrap on x86_64-linux-gnu (with regtest queued) and it seems very very unlikely to break anything else. Seems reasonable.Thanks for taking care of

[PATCH 3/8] add default for PCC_BITFIELD_TYPE_MATTERS

2015-04-26 Thread tbsaunde+gcc
From: Trevor Saunders tbsaunde+...@tbsaunde.org gcc/ChangeLog: 2015-04-27 Trevor Saunders tbsaunde+...@tbsaunde.org * defaults.h (PCC_BITFIELD_TYPE_MATTERS): Add default definition to false. * dwarf2out.c (field_byte_offset): REmove check if