Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-02-03 Thread Wilco Dijkstra
James Greenhalgh wrote: > I'm still seeing: > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times \\tcmp\\tw[0-9]+, > (0|wzr) 4 That's because "(0|wzr)" is not correctly matching due to the weird regular expression syntax used in the testsuite (I tried with several escapes to no avail). I

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-02-03 Thread James Greenhalgh
On Thu, Jan 28, 2016 at 02:33:20PM +, James Greenhalgh wrote: > On Mon, Jan 25, 2016 at 08:09:39PM +, Wilco Dijkstra wrote: > > Andreas Schwab wrote: > > > > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times \tcmp\tw[0-9]+, 0 4 > > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-28 Thread James Greenhalgh
On Mon, Jan 25, 2016 at 08:09:39PM +, Wilco Dijkstra wrote: > Andreas Schwab wrote: > > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times \tcmp\tw[0-9]+, 0 4 > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler adds\t > > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times fccmpe\t.

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-25 Thread Richard Henderson
On 01/25/2016 12:09 PM, Wilco Dijkstra wrote: > BTW is there a regular expression that correctly implements (0|xzr)? (0|wzr) works fine for me; I've got exactly that fix in one of my trees. r~

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-25 Thread Wilco Dijkstra
Andreas Schwab wrote: > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times \tcmp\tw[0-9]+, 0 4 > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler adds\t > FAIL: gcc.target/aarch64/ccmp_1.c scan-assembler-times fccmpe\t.*0\\.0 1 Yes I noticed those too, and here is the fix. Richard's recent c

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-23 Thread Andreas Schwab
"Wilco Dijkstra" writes: > diff --git a/gcc/testsuite/gcc.target/aarch64/ccmp_1.c > b/gcc/testsuite/gcc.target/aarch64/ccmp_1.c > index ef077e0..7c39b61 100644 > --- a/gcc/testsuite/gcc.target/aarch64/ccmp_1.c > +++ b/gcc/testsuite/gcc.target/aarch64/ccmp_1.c > @@ -80,5 +80,16 @@ f13 (int a, int

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-22 Thread Andreas Schwab
This breaks bootstrap on aarch64 by miscompiling the stage2 compiler. ../../../libgomp/priority_queue.h:422:11: internal compiler error: RTL flag check: MEM_VOLATILE_P used with unexpected rtx code 'mem' in set_mem_attributes_minus_bitpos, at emit-rtl.c:1833 if (list->tasks == node) ~~

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-19 Thread Wilco Dijkstra
H.J. Lu wrote: > It breaks bootstrap on Linux/x86: Committed trivial fix as r232576: Index: gcc/ChangeLog === --- gcc/ChangeLog(revision 232575) +++ gcc/ChangeLog(working copy) @@ -1,3 +1,7 @@ +2016-01-19 Wilco Dijkstra +

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-19 Thread Wilco Dijkstra
H.J. Lu wrote: > It breaks bootstrap on Linux/x86: Sorry about that - it looks like the warning levels seem to have changed since that patch was tested... I have a trivial fix which I'll get checked in soon. Wilco

Re: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2016-01-19 Thread H.J. Lu
On Tue, Dec 15, 2015 at 2:33 AM, Wilco Dijkstra wrote: > ping > >> -Original Message- >> From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] >> Sent: 13 November 2015 16:03 >> To: 'gcc-patches@gcc.gnu.org' >> Subject: [PATCH 4/4][AArc

RE: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2015-12-15 Thread Wilco Dijkstra
ping > -Original Message- > From: Wilco Dijkstra [mailto:wilco.dijks...@arm.com] > Sent: 13 November 2015 16:03 > To: 'gcc-patches@gcc.gnu.org' > Subject: [PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose > better expand order > > This patc

[PATCH 4/4][AArch64] Cost CCMP instruction sequences to choose better expand order

2015-11-13 Thread Wilco Dijkstra
This patch adds CCMP selection based on rtx costs. This is based on Jiong's already approved patch https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01434.html with some minor refactoring and the tests updated. OK for commit? ChangeLog: 2015-11-13 Jiong Wang gcc/ * ccmp.c (expand_ccmp_exp