Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-07 Thread Iain Sandoe
> On 3 Jan 2019, at 23:10, Ian Lance Taylor wrote: > > On Thu, Jan 3, 2019 at 3:49 AM Iain Sandoe wrote: >> >>> On 2 Jan 2019, at 13:26, Iain Sandoe wrote: >>> >>> On 2 Jan 2019, at 13:20, Rainer Orth wrote: Gerald Pfeifer writes: > >> > > I believe t

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-03 Thread Ian Lance Taylor via gcc-patches
On Thu, Jan 3, 2019 at 3:49 AM Iain Sandoe wrote: > > > On 2 Jan 2019, at 13:26, Iain Sandoe wrote: > > > > > >> On 2 Jan 2019, at 13:20, Rainer Orth wrote: > >> > >> Gerald Pfeifer writes: > >> > >>> > > >>> > >>> I believe that in addition to FreeBSD this probably also fails on > >>> Solaris

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-03 Thread Tom de Vries
On 02-01-19 14:20, Rainer Orth wrote: > Unfortunately, libbacktrace is one of those libraries that don't produce > Dejagnu-style .sum and .log files, so test failures are buried in the > make check output and very easily overlooked. FTR, I've filed PR88002 - "libbacktrace and libiberty tests don't

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-03 Thread Iain Sandoe
> On 2 Jan 2019, at 13:26, Iain Sandoe wrote: > > >> On 2 Jan 2019, at 13:20, Rainer Orth wrote: >> >> Gerald Pfeifer writes: >> >>> >>> >>> I believe that in addition to FreeBSD this probably also fails on >>> Solaris and Darwin. >> >> I cannot test Darwin right now, > > I have build

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-02 Thread Iain Sandoe
> On 2 Jan 2019, at 13:20, Rainer Orth wrote: > > Gerald Pfeifer writes: > >> On Fri, 23 Nov 2018, Tom de Vries wrote: >>> When building libbacktrace, we typically use elf.c, and don't build >>> pecoff.c, xcoff.c or unknown.c >>> >>> Add testcases that use unused format to ensure that we al

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2019-01-02 Thread Rainer Orth
Gerald Pfeifer writes: > On Fri, 23 Nov 2018, Tom de Vries wrote: >> When building libbacktrace, we typically use elf.c, and don't build >> pecoff.c, xcoff.c or unknown.c >> >> Add testcases that use unused format to ensure that we also build and >> test those on a typical development setup. >

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-29 Thread Gerald Pfeifer
On Sun, 30 Dec 2018, Tom de Vries wrote: > thanks for finding this. > > I build the patch for x86_64 and ran make check in the libbacktrace > subdirectory of the build directory, results looks good. Cool, thanks! I went ahead and committed this fix. Note, that I *may* be offline the next nine d

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-29 Thread Tom de Vries
On 29-12-18 07:40, Gerald Pfeifer wrote: > On Fri, 23 Nov 2018, Tom de Vries wrote: >> When building libbacktrace, we typically use elf.c, and don't build >> pecoff.c, xcoff.c or unknown.c >> >> Add testcases that use unused format to ensure that we also build and >> test those on a typical develo

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-29 Thread Gerald Pfeifer
On Fri, 28 Dec 2018, Gerald Pfeifer wrote: > The patch below should address this (and does in my tests), though > my tester seems to have unrelated(?) problems right now, so better > for one of you to give a spin as well, please. Now successfully regression tested on i586-unknown-freebsd11.2. >

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-12-28 Thread Gerald Pfeifer
On Fri, 23 Nov 2018, Tom de Vries wrote: > When building libbacktrace, we typically use elf.c, and don't build > pecoff.c, xcoff.c or unknown.c > > Add testcases that use unused format to ensure that we also build and > test those on a typical development setup. This is a good idea! > Bootstrap

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-30 Thread Ian Lance Taylor via gcc-patches
On Fri, Nov 30, 2018 at 1:06 AM, Tom de Vries wrote: > On 29-11-18 19:28, Ian Lance Taylor wrote: >> On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries wrote: >>> >>> When building libbacktrace, we typically use elf.c, and don't build >>> pecoff.c, >>> xcoff.c or unknown.c >>> >>> Add testcases that

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-30 Thread Tom de Vries
On 29-11-18 19:28, Ian Lance Taylor wrote: > On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries wrote: >> >> When building libbacktrace, we typically use elf.c, and don't build pecoff.c, >> xcoff.c or unknown.c >> >> Add testcases that use unused format to ensure that we also build and >> test those o

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-29 Thread Ian Lance Taylor via gcc-patches
On Fri, Nov 23, 2018 at 12:56 PM, Tom de Vries wrote: > > When building libbacktrace, we typically use elf.c, and don't build pecoff.c, > xcoff.c or unknown.c > > Add testcases that use unused format to ensure that we also build and > test those on a typical development setup. > > Bootstrapped and

Re: [PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-28 Thread Tom de Vries
On 23-11-18 21:56, Tom de Vries wrote: > Hi, > > When building libbacktrace, we typically use elf.c, and don't build pecoff.c, > xcoff.c or unknown.c > > Add testcases that use unused format to ensure that we also build and > test those on a typical development setup. > > Bootstrapped and reg-te

[PATCH 4/4][libbacktrace] Add tests for unused formats

2018-11-23 Thread Tom de Vries
Hi, When building libbacktrace, we typically use elf.c, and don't build pecoff.c, xcoff.c or unknown.c Add testcases that use unused format to ensure that we also build and test those on a typical development setup. Bootstrapped and reg-tested on x86_64. OK for trunk? Thanks, - Tom [libbacktr