Re: [committed] move constant to the right of relational operators (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-31 Thread Martin Sebor
On 01/31/2017 01:49 PM, Bernhard Reutner-Fischer wrote: On 31 January 2017 00:19:46 CET, Martin Sebor wrote: So I see the introduction of many if (const OP object) expressions Can you please fix those as an independent patch after #4 and #5 are installed on the trunk? Consider that patch pre

Re: [committed] move constant to the right of relational operators (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-31 Thread Bernhard Reutner-Fischer
On 31 January 2017 00:19:46 CET, Martin Sebor wrote: >> So I see the introduction of many >> >> if (const OP object) expressions >> >> Can you please fix those as an independent patch after #4 and #5 are >> installed on the trunk? Consider that patch pre-approved, but please >> post it here for t

[committed] move constant to the right of relational operators (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-30 Thread Martin Sebor
So I see the introduction of many if (const OP object) expressions Can you please fix those as an independent patch after #4 and #5 are installed on the trunk? Consider that patch pre-approved, but please post it here for the historical record. I think a regexp of paren followed by a constant

Re: [committed] clean up preprocessor conditional (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-27 Thread Christophe Lyon
On 27 January 2017 at 03:49, Martin Sebor wrote: > I committed the patch below to clean up the "mess." > > Thanks > Martin > > Index: gcc/gimple-ssa-sprintf.c > === > --- gcc/gimple-ssa-sprintf.c(revision 244957) > +++ gcc/gimple-

[committed] clean up preprocessor conditional (Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703))

2017-01-26 Thread Martin Sebor
I committed the patch below to clean up the "mess." Thanks Martin Index: gcc/gimple-ssa-sprintf.c === --- gcc/gimple-ssa-sprintf.c(revision 244957) +++ gcc/gimple-ssa-sprintf.c(working copy) @@ -1686,20 +1686,10 @@ format_fl

Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703)

2017-01-26 Thread Andrew Pinski
On Thu, Jan 26, 2017 at 3:17 PM, Martin Sebor wrote: >> Hi, >> >> With this patch all my builds for aarch64/arm failed: >> /gcc/gimple-ssa-sprintf.c: In function >> ‘::fmtresult::format_floating(const::direc >> tive&, tree_node*)’: >> /gcc/gimple-ssa-sprintf.c:1643: error: ‘XFmode’ was not declare

Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703)

2017-01-26 Thread Martin Sebor
On 01/26/2017 04:17 PM, Martin Sebor wrote: Hi, With this patch all my builds for aarch64/arm failed: /gcc/gimple-ssa-sprintf.c: In function ‘::fmtresult::format_floating(const::direc tive&, tree_node*)’: /gcc/gimple-ssa-sprintf.c:1643: error: ‘XFmode’ was not declared in this scope Is this fix

Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703)

2017-01-26 Thread Martin Sebor
Hi, With this patch all my builds for aarch64/arm failed: /gcc/gimple-ssa-sprintf.c: In function ‘::fmtresult::format_floating(const::direc tive&, tree_node*)’: /gcc/gimple-ssa-sprintf.c:1643: error: ‘XFmode’ was not declared in this scope Is this fixed later in the series? It isn't. I just r

Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703)

2017-01-26 Thread Christophe Lyon
On 26 January 2017 at 00:31, Jeff Law wrote: > On 01/22/2017 04:53 PM, Martin Sebor wrote: >> >> The attached patch adds the concept of likely and unlikely results >> of formatted functions to improve the quality of diagnostics (reduce >> false positives and negatives) while at the same time allow

Re: [PATCH 4/5] distinguish likely and unlikely results (PR 78703)

2017-01-25 Thread Jeff Law
On 01/22/2017 04:53 PM, Martin Sebor wrote: The attached patch adds the concept of likely and unlikely results of formatted functions to improve the quality of diagnostics (reduce false positives and negatives) while at the same time allowing for rare cases such as a multibyte decimal point in fl