Re: [PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-16 Thread Kito Cheng
On Tue, Jul 16, 2024 at 4:25 PM Christoph Müllner wrote: > > On Tue, Jul 16, 2024 at 4:45 AM Kito Cheng wrote: > > > > On Tue, Jul 16, 2024 at 1:09 AM Christoph Müllner > > wrote: > > > > > > On Mon, Jul 15, 2024 at 11:10 AM Kito Cheng wrote: > > > > > > > > LGTM, and could you backport this

Re: [PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-16 Thread Christoph Müllner
On Tue, Jul 16, 2024 at 4:45 AM Kito Cheng wrote: > > On Tue, Jul 16, 2024 at 1:09 AM Christoph Müllner > wrote: > > > > On Mon, Jul 15, 2024 at 11:10 AM Kito Cheng wrote: > > > > > > LGTM, and could you backport this to the GCC 14 branch as well? > > > > Rebased, retested (multilib), fixed an

Re: [PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-15 Thread Kito Cheng
On Tue, Jul 16, 2024 at 1:09 AM Christoph Müllner wrote: > > On Mon, Jul 15, 2024 at 11:10 AM Kito Cheng wrote: > > > > LGTM, and could you backport this to the GCC 14 branch as well? > > Rebased, retested (multilib), fixed an issue related to Zca/Zcd and pushed. > > Should the GCC 14 backport

Re: [PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-15 Thread Christoph Müllner
On Mon, Jul 15, 2024 at 11:10 AM Kito Cheng wrote: > > LGTM, and could you backport this to the GCC 14 branch as well? Rebased, retested (multilib), fixed an issue related to Zca/Zcd and pushed. Should the GCC 14 backport be posted for review before pushing? Thanks, Christoph > > On Tue, Jul

Re: [PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-15 Thread Kito Cheng
LGTM, and could you backport this to the GCC 14 branch as well? On Tue, Jul 9, 2024 at 8:50 PM Christoph Müllner wrote: > > The target-arch attribute handling in RISC-V is only a few months old, > but already saw a rewrite (9941f0295a14), which addressed an important > issue. This rewrite

[PATCH 5/6] RISC-V: Rewrite target attribute handling

2024-07-09 Thread Christoph Müllner
The target-arch attribute handling in RISC-V is only a few months old, but already saw a rewrite (9941f0295a14), which addressed an important issue. This rewrite introduced a hash table in the backend, which is used to keep track of target-arch attributes of all functions. The index of this hash