Re: [PATCH 5/6] vect: Support multiple lane-reducing operations for loop reduction [PR114440]

2024-06-04 Thread Richard Biener
On Sun, Jun 2, 2024 at 4:13 PM Feng Xue OS wrote: > > Please see my comments below. > > Thanks, > Feng > > > On Thu, May 30, 2024 at 4:55 PM Feng Xue OS > > wrote: > >> > >> For lane-reducing operation(dot-prod/widen-sum/sad) in loop reduction, > >> current > >> vectorizer could only handle the

Re: [PATCH 5/6] vect: Support multiple lane-reducing operations for loop reduction [PR114440]

2024-06-02 Thread Feng Xue OS
Please see my comments below. Thanks, Feng > On Thu, May 30, 2024 at 4:55 PM Feng Xue OS > wrote: >> >> For lane-reducing operation(dot-prod/widen-sum/sad) in loop reduction, >> current >> vectorizer could only handle the pattern if the reduction chain does not >> contain other operation, no m

Re: [PATCH 5/6] vect: Support multiple lane-reducing operations for loop reduction [PR114440]

2024-05-31 Thread Richard Biener
On Thu, May 30, 2024 at 4:55 PM Feng Xue OS wrote: > > For lane-reducing operation(dot-prod/widen-sum/sad) in loop reduction, current > vectorizer could only handle the pattern if the reduction chain does not > contain other operation, no matter the other is normal or lane-reducing. > > Actually,

[PATCH 5/6] vect: Support multiple lane-reducing operations for loop reduction [PR114440]

2024-05-30 Thread Feng Xue OS
13296,6 +13296,8 @@ vect_analyze_stmt (vec_info *vinfo, NULL, NULL, node, cost_vec) || vectorizable_load (vinfo, stmt_info, NULL, NULL, node, cost_vec) || vectorizable_store (vinfo, stmt_info, NULL, NULL, node, cost_vec) + || vectoriza