Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-12-12 Thread Jakub Jelinek
On Fri, Dec 12, 2014 at 10:58:39AM +0100, Thomas Schwinge wrote: > > --- /dev/null > > +++ b/libgomp/libgomp_target.h > > @@ -0,0 +1,44 @@ > > +/* Copyright (C) 2014 Free Software Foundation, Inc. > > + > > + This file is part of the GNU OpenMP Library (libgomp). > > > +#ifndef LIBGOMP_TARGET_H

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-12-12 Thread Thomas Schwinge
Hi! I know, I'm a little late, but: On Mon, 6 Oct 2014 19:53:17 +0400, Ilya Verbin wrote: > This patch adds plugin support to libgomp, as well as memory mapping and > interaction with target devices through plugin's interface. > libgomp/ > * libgomp_target.h: New file. > --- /dev/null >

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-24 Thread Ilya Verbin
On 24 Oct 18:07, Jakub Jelinek wrote: > On Fri, Oct 24, 2014 at 08:03:42PM +0400, Ilya Verbin wrote: > > A small addition, refcount and copy_from were uninitialized for globals. > > > > > > diff --git a/libgomp/target.c b/libgomp/target.c > > index 4ace170..5b4873b 100644 > > --- a/libgomp/target

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-24 Thread Jakub Jelinek
On Fri, Oct 24, 2014 at 08:03:42PM +0400, Ilya Verbin wrote: > A small addition, refcount and copy_from were uninitialized for globals. > > > diff --git a/libgomp/target.c b/libgomp/target.c > index 4ace170..5b4873b 100644 > --- a/libgomp/target.c > +++ b/libgomp/target.c > @@ -647,6 +647,8 @@ go

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-24 Thread Ilya Verbin
On 08 Oct 13:08, Jakub Jelinek wrote: > On Mon, Oct 06, 2014 at 07:53:17PM +0400, Ilya Verbin wrote: > > libgomp/ > > * libgomp.map (GOMP_4.0.1): New symbol version. > > Add GOMP_offload_register. > > * libgomp_target.h: New file. > > * splay-tree.h: New file. > > * target.c: In

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-08 Thread Ilya Verbin
I rebased and updated kyukhin/gomp4-offload branch. It contains renaming of sections/symbols and fixes the cleanup of temporary directories in the offload emulator. On 07 Oct 21:40, Jakub Jelinek wrote: > One more thing, I've noticed that running target-1.exe testcase also leaves > /tmp/offload_XX

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-08 Thread Jakub Jelinek
On Mon, Oct 06, 2014 at 07:53:17PM +0400, Ilya Verbin wrote: > 2014-10-06 Jakub Jelinek > Ilya Verbin > Thomas Schwinge > Andrey Turetskiy > > libgomp/ > * libgomp.map (GOMP_4.0.1): New symbol version. > Add GOMP_offload_register. > * libgom

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-08 Thread Kirill Yukhin
Hello Jakub, On 07 Oct 21:40, Jakub Jelinek wrote: > On Tue, Oct 07, 2014 at 10:12:22PM +0400, Ilya Verbin wrote: > OT, from the various IRC discussions with Kirill on IRC, it seems you or > your colleges typed pretty much all target related tests from OpenMP 4.0.1 > examples, can those be also sub

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 10:12:22PM +0400, Ilya Verbin wrote: > > And, is __gnu_offload_{funcs,vars} named that way just because the plugin > > isn't able to add > > symbols around the sections for you? As it doesn't contain a dot, it would > > collide > > with user declarations put into __attrib

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 16:30, Jakub Jelinek wrote: > I think it is useful, doesn't have to be in the initial checkin, but I'd > certainly prefer if from the (optional) --enable-offload-target argument > it would figure out everything it needs to add for testing. > And, if mkoffload isn't flexible enough to be c

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 16:30, Jakub Jelinek wrote: > Another thing I've noticed, when target-1.exe is built, there are tons of > sections that IMHO should have been stripped away: Could you please re-checkout the branch? I fixed this issue a week ago. Thanks, -- Ilya

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
Hi! Also, something that I believe has been discussed in the past, but can't find it on your wiki page nor in *.opt, are option overrides for the offloading target, i.e. some option you can pass to the host compiler driver during linking that will tell the driver for which offloading targets (if a

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Tue, Oct 07, 2014 at 05:51:53PM +0400, Ilya Verbin wrote: > On 07 Oct 15:06, Jakub Jelinek wrote: > > Still have issues with the non-installed testing. > > The idea was that the offload compiler should be installed. > > > If I add > > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-lin

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Thomas Schwinge
Hi! On Tue, 7 Oct 2014 17:51:53 +0400, Ilya Verbin wrote: > On 07 Oct 15:06, Jakub Jelinek wrote: > > Still have issues with the non-installed testing. > > The idea was that the offload compiler should be installed. > > > If I add > > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-linu

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Ilya Verbin
On 07 Oct 15:06, Jakub Jelinek wrote: > Still have issues with the non-installed testing. The idea was that the offload compiler should be installed. > If I add > -B /usr/src/gcc-git/objinst/usr/local/lib/gcc/x86_64-pc-linux-gnu/5.0.0/ \ > -B /usr/src/gcc-git/objinst/usr/local/libexec/gcc/x86_64-

Re: [PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-07 Thread Jakub Jelinek
On Mon, Oct 06, 2014 at 07:53:17PM +0400, Ilya Verbin wrote: > This patch adds plugin support to libgomp, as well as memory mapping and > interaction with target devices through plugin's interface. Still have issues with the non-installed testing. ( mkdir objmic && cd objmic && ../configure --bu

[PATCH 5/n] OpenMP 4.0 offloading infrastructure: libgomp

2014-10-06 Thread Ilya Verbin
Hello, This patch adds plugin support to libgomp, as well as memory mapping and interaction with target devices through plugin's interface. Bootstrapped and regtested on top of patch 4. Is it OK for trunk? Thanks, -- Ilya 2014-10-06 Jakub Jelinek Ilya Verbin Tho