Re: Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Tue, Jun 10, 2014 at 8:47 AM, Thomas Schwinge wrote: > Hi! > > On Tue, 3 Jun 2014 11:55:44 +0200, I wrote: >> Ping -- OK to commit to trunk? > > Even though several of those who I'd consider regular GCC developers do > agree with this patch (see also ), that is > no

Re: Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Mon, Jun 9, 2014 at 11:47 PM, Thomas Schwinge wrote: > Hi! > > On Tue, 3 Jun 2014 11:55:44 +0200, I wrote: >> Ping -- OK to commit to trunk? > > Even though several of those who I'd consider regular GCC developers do > agree with this patch (see also ), that is > no

Commit policy? Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Hi! On Tue, 3 Jun 2014 11:55:44 +0200, I wrote: > Ping -- OK to commit to trunk? Even though several of those who I'd consider regular GCC developers do agree with this patch (see also ), that is not enough "consensus" to consider this patch approved, right? Wouldn't

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Hi! Ping -- OK to commit to trunk? On Wed, 28 May 2014 23:55:31 +0200, Jan Hubicka wrote: > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski wrote: > > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres > > > wrote: > > > > r210901 breaks bootstrap on targets not supporting strnlen, e.

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> Hi! > > On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski wrote: > > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres > > wrote: > > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., > > > darwin10. > > > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Hi! On Mon, 26 May 2014 02:16:35 -0700, Andrew Pinski wrote: > On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres > wrote: > > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10. > > > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in > > th

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Jan Hubicka writes: >> This patch broke Solaris bootstrap: >> >> /vol/gcc/src/hg/trunk/local/gcc/config/sol2.c: In function 'void >> solaris_elf_asm_comdat_section(const char*, unsigned int, tree)': >> /vol/gcc/src/hg/trunk/local/gcc/config/sol2.c:213:17: error: >> 'decl_comdat_group' was not

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> > This patch broke Solaris bootstrap: > > /vol/gcc/src/hg/trunk/local/gcc/config/sol2.c: In function 'void > solaris_elf_asm_comdat_section(const char*, unsigned int, tree)': > /vol/gcc/src/hg/trunk/local/gcc/config/sol2.c:213:17: error: > 'decl_comdat_group' was not declared in this scope >

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> On my side, I can see that r210901 breaks AArch64 compiler build: > gcc/config/aarch64/aarch64.c: In function ‘void > aarch64_elf_asm_named_section(const char*, unsigned int, tree_node*)’: > gcc/config/aarch64/aarch64.c:8136: error: ‘decl_comdat_group’ was not > declared in this scope This sould

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Jan Hubicka writes: >> I'm fine with enlarging tree_function_decl for now - ideally we'd push >> stuff from it elsewhere (like target and optimization option tree nodes, >> or most of the visibility and symbol related stuff). Not sure why >> tree_type_decl inherits from tree_decl_non_common (and

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On my side, I can see that r210901 breaks AArch64 compiler build: gcc/config/aarch64/aarch64.c: In function ‘void aarch64_elf_asm_named_section(const char*, unsigned int, tree_node*)’: gcc/config/aarch64/aarch64.c:8136: error: ‘decl_comdat_group’ was not declared in this scope Christophe. On 26

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Mon, May 26, 2014 at 1:59 AM, Dominique Dhumieres wrote: > r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10. > > ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in > this scope strnlen should be declared in include/libiberty.h if there is no d

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

r210901 breaks bootstrap on targets not supporting strnlen, e.g., darwin10. ../../_clean/gcc/lto-cgraph.c:976:68: error: 'strnlen' was not declared in this scope libgfortran/configure defines HAVE_STRNLEN on targets supporting it. The same revision also breaks the test g++.dg/tls/diag-1.C /opt

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> On Thu, May 22, 2014 at 2:49 PM, Martin Jambor wrote: > > Hi, > > > > On Wed, May 21, 2014 at 04:27:32PM +0200, Richard Biener wrote: > >> On Wed, May 21, 2014 at 3:16 PM, Martin Jambor wrote: > >> > Hi, > >> > > >> > this demonstrates how results of ipa-prop escape analysis from > >> > previou

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> I'm fine with enlarging tree_function_decl for now - ideally we'd push > stuff from it elsewhere (like target and optimization option tree nodes, > or most of the visibility and symbol related stuff). Not sure why > tree_type_decl inherits from tree_decl_non_common (and thus > tree_decl_with_vis

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> Well, allocate_struct_function has a abstract_p argument for that. But > yes, a simple patch like > > Index: gcc/function.c > === > --- gcc/function.c (revision 210845) > +++ gcc/function.c (working copy) > @@ -64,6 +64,7

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Thu, May 22, 2014 at 8:11 PM, Jan Hubicka wrote: >> >It won't be so easy, because struct function is really built at >> >relatively convoluted >> >places within frontend before cgraph node is assigned to them (I tried >> >that few years >> >back). >> >> Well, just call cgraph create node from s

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> >It won't be so easy, because struct function is really built at > >relatively convoluted > >places within frontend before cgraph node is assigned to them (I tried > >that few years > >back). > > Well, just call cgraph create node from struct Funktion allocation. That will make uninstantiated t

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On May 22, 2014 5:24:33 PM CEST, Jan Hubicka wrote: >> >> Can we? If the body is not readily available we only have decl and >> cgraph-node, not struct function. >> >> I suppose we could exchange the struct function pointer in >> tree_function_decl for a cgraph_node pointer and put >> the struc

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

> > Can we? If the body is not readily available we only have decl and > cgraph-node, not struct function. > > I suppose we could exchange the struct function pointer in > tree_function_decl for a cgraph_node pointer and put > the struct function pointer into the cgraph_node. > > Of course that

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Thu, May 22, 2014 at 2:49 PM, Martin Jambor wrote: > Hi, > > On Wed, May 21, 2014 at 04:27:32PM +0200, Richard Biener wrote: >> On Wed, May 21, 2014 at 3:16 PM, Martin Jambor wrote: >> > Hi, >> > >> > this demonstrates how results of ipa-prop escape analysis from >> > previous patches can be u

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Hi, On Wed, May 21, 2014 at 04:27:32PM +0200, Richard Biener wrote: > On Wed, May 21, 2014 at 3:16 PM, Martin Jambor wrote: > > Hi, > > > > this demonstrates how results of ipa-prop escape analysis from > > previous patches can be used at a later stage of compilation by > > directly returning the

Re: [PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

On Wed, May 21, 2014 at 3:16 PM, Martin Jambor wrote: > Hi, > > this demonstrates how results of ipa-prop escape analysis from > previous patches can be used at a later stage of compilation by > directly returning them from gimple_call_arg_flags which currently > relies on fnspec annotations. > >

[PATCH 7/7] Plug ipa-prop escape analysis into gimple_call_arg_flags

Hi, this demonstrates how results of ipa-prop escape analysis from previous patches can be used at a later stage of compilation by directly returning them from gimple_call_arg_flags which currently relies on fnspec annotations. Bootstrapped and tested on x86_64-linux and also passes LTO bootstrap