Re: [PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-07-15 Thread James Greenhalgh
On Wed, Jul 15, 2015 at 09:22:01AM +0100, Bin.Cheng wrote: > Ping^2 > +/* ADD -(immediate). */ I'd like to see a more detailed comment in this case. Probably something along the lines of: /* The canonical form of subtract of immediate is (add op0 minus_imm). Catch that here, m

Re: [PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-07-15 Thread Bin.Cheng
Ping^2 On Thu, Jul 9, 2015 at 5:42 PM, Bin.Cheng wrote: > Ping. > > On Fri, Jun 26, 2015 at 4:47 PM, Bin Cheng wrote: >> Hi, >> The canonical form of subtract of immediate is (add op0 minus_imm), which is >> supported with addsi3_aarch64 pattern on aarch64. Unfortunately wrong cost >> (8 rather

Re: [PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-07-09 Thread Bin.Cheng
Ping. On Fri, Jun 26, 2015 at 4:47 PM, Bin Cheng wrote: > Hi, > The canonical form of subtract of immediate is (add op0 minus_imm), which is > supported with addsi3_aarch64 pattern on aarch64. Unfortunately wrong cost > (8 rather than 4) is computed by aarch64_rtx_cost because it doesn't honor >

[PATCH AArch64]Handle wrong cost for addition of minus immediate in aarch64_rtx_costs.

2015-06-26 Thread Bin Cheng
Hi, The canonical form of subtract of immediate is (add op0 minus_imm), which is supported with addsi3_aarch64 pattern on aarch64. Unfortunately wrong cost (8 rather than 4) is computed by aarch64_rtx_cost because it doesn't honor the fact that it actually is a sub instruction. This patch fixes i