Re: [PATCH RFA] expand: empty class return optimization [PR88529]

2021-06-22 Thread Joseph Myers
This introduces an ICE building libgomp for ColdFire, as detected by my glibc bot. https://gcc.gnu.org/bugzilla/show_bug.cgi?id=101170 -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH RFA] expand: empty class return optimization [PR88529]

2021-06-21 Thread Richard Biener via Gcc-patches
On Tue, Jun 15, 2021 at 5:25 AM Jason Merrill via Gcc-patches wrote: > > The x86_64 psABI says that an empty class isn't passed or returned in memory > or > registers, so we shouldn't set %eax in this function. Is this a reasonable > place to implement that? Another possibility would be to remo

[PATCH RFA] expand: empty class return optimization [PR88529]

2021-06-14 Thread Jason Merrill via Gcc-patches
The x86_64 psABI says that an empty class isn't passed or returned in memory or registers, so we shouldn't set %eax in this function. Is this a reasonable place to implement that? Another possibility would be to remove the hack to prevent i386.c:function_value_64 from returning NULL in this case