Re: [PATCH V12]: Improve code sinking pass

2024-03-14 Thread Richard Biener
On Wed, Mar 13, 2024 at 9:27 PM Jeff Law wrote: > > > > On 3/13/24 4:22 AM, Richard Biener wrote: > > > > > ... this hunk is OK (please test and split it out separatley). In the > > spirit of > > moving the stmt the least amount (in this case not schedule it within the > > basic-block). In the

Re: [PATCH V12]: Improve code sinking pass

2024-03-13 Thread Jeff Law
On 3/13/24 4:22 AM, Richard Biener wrote: ... this hunk is OK (please test and split it out separatley). In the spirit of moving the stmt the least amount (in this case not schedule it within the basic-block). In the same spirit one would choose an earlier basic-block but only if the old

Re: [PATCH V12]: Improve code sinking pass

2024-03-13 Thread Richard Biener
On Wed, Mar 13, 2024 at 10:02 AM Ajit Agarwal wrote: > > Hello All: > > Currently, code sinking will sink code at the use points with loop having same > nesting depth. The following patch improves code sinking by placing the sunk > code in immediate dominator with same loop nest depth. > >

[PATCH V12]: Improve code sinking pass

2024-03-13 Thread Ajit Agarwal
Hello All: Currently, code sinking will sink code at the use points with loop having same nesting depth. The following patch improves code sinking by placing the sunk code in immediate dominator with same loop nest depth. Changes since v11: Reorganization of the code. For example : void