Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-13 Thread Hongyu Wang via Gcc-patches
> Ok, Note GCC documents have been ported to sphinx, so you need to > adjust changes in invoke.texi to new sphinx files. Yes, this is the patch I'm going to check-in. Thanks. Hongtao Liu 于2022年11月14日周一 09:35写道: > > On Wed, Nov 9, 2022 at 9:29 AM Hongyu Wang wrote: > > > > > Although

Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-13 Thread Hongtao Liu via Gcc-patches
On Wed, Nov 9, 2022 at 9:29 AM Hongyu Wang wrote: > > > Although ix86_small_unroll_insns is coming from issue_rate, it's tuned > > for codesize. > > Make it exact as issue_rate and using factor * issue_width / > > loop->ninsns may increase code size too much. > > So I prefer to add those 2

RE: [PATCH V2] Enable small loop unrolling for O2

2022-11-10 Thread Wang, Hongyu via Gcc-patches
Thanks for the notification! I’m not aware of the compile farm before. Will see what’s the impact of my patch then. Regards, Hongyu, Wang From: David Edelsohn Sent: Thursday, November 10, 2022 1:22 AM To: Wang, Hongyu Cc: GCC Patches Subject: Re: [PATCH V2] Enable small loop unrolling for O2

Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-09 Thread David Edelsohn via Gcc-patches
> This patch does not change rs6000/s390 since I don't have machines to > test them, but I suppose the default behavior is the same since they > enable flag_unroll_loops at O2. There are Power (rs6000) systems in the Compile Farm. Trial Linux on Z (s390x) VMs are available through the Linux

Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-08 Thread Hongyu Wang via Gcc-patches
> Although ix86_small_unroll_insns is coming from issue_rate, it's tuned > for codesize. > Make it exact as issue_rate and using factor * issue_width / > loop->ninsns may increase code size too much. > So I prefer to add those 2 parameters to the cost table for core > tunings instead of 1. Yes,

Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-07 Thread Hongtao Liu via Gcc-patches
On Mon, Nov 7, 2022 at 10:25 PM Richard Biener via Gcc-patches wrote: > > On Wed, Nov 2, 2022 at 4:37 AM Hongyu Wang wrote: > > > > Hi, this is the updated patch of > > https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604345.html, > > which uses targetm.loop_unroll_adjust as gate to enable

Re: [PATCH V2] Enable small loop unrolling for O2

2022-11-07 Thread Richard Biener via Gcc-patches
On Wed, Nov 2, 2022 at 4:37 AM Hongyu Wang wrote: > > Hi, this is the updated patch of > https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604345.html, > which uses targetm.loop_unroll_adjust as gate to enable small loop unroll. > > This patch does not change rs6000/s390 since I don't have

[PATCH V2] Enable small loop unrolling for O2

2022-11-01 Thread Hongyu Wang via Gcc-patches
Hi, this is the updated patch of https://gcc.gnu.org/pipermail/gcc-patches/2022-October/604345.html, which uses targetm.loop_unroll_adjust as gate to enable small loop unroll. This patch does not change rs6000/s390 since I don't have machine to test them, but I suppose the default behavior is