Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-15 Thread guojiufu via Gcc-patches
On 2021-07-15 14:06, Richard Biener wrote: On Tue, 13 Jul 2021, Jiufu Guo wrote: Major changes from v1: * Add target hook to query preferred doloop mode. * Recompute doloop iv base from niter under preferred mode. Currently, doloop.xx variable is using the type as niter which may shorter

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-15 Thread Jiufu Guo via Gcc-patches
Iain Sandoe writes: On 15 Jul 2021, at 06:09, guojiufu via Gcc-patches wrote: On 2021-07-15 02:04, Segher Boessenkool wrote: +@deftypefn {Target Hook} machine_mode TARGET_PREFERRED_DOLOOP_MODE (machine_mode @var{mode}) +This hook takes a @var{mode} which is the original mode of doloop

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-15 Thread Iain Sandoe via Gcc-patches
> On 15 Jul 2021, at 06:09, guojiufu via Gcc-patches > wrote: > > On 2021-07-15 02:04, Segher Boessenkool wrote: > >>> +@deftypefn {Target Hook} machine_mode TARGET_PREFERRED_DOLOOP_MODE >>> (machine_mode @var{mode}) >>> +This hook takes a @var{mode} which is the original mode of doloop

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-15 Thread Richard Biener
On Tue, 13 Jul 2021, Jiufu Guo wrote: > Major changes from v1: > * Add target hook to query preferred doloop mode. > * Recompute doloop iv base from niter under preferred mode. > > Currently, doloop.xx variable is using the type as niter which may shorter > than word size. For some cases, it

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-14 Thread guojiufu via Gcc-patches
On 2021-07-15 02:04, Segher Boessenkool wrote: Hi! On Wed, Jul 14, 2021 at 06:26:28PM +0800, guojiufu wrote: PR target/61837 Wrong PR number? There is a patch optimize "add -1; zero_ext; add +1" to "zero_ext" already. Having this patch would help to avoid the left 'zero_ext', so,

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-14 Thread Segher Boessenkool
Hi! On Wed, Jul 14, 2021 at 06:26:28PM +0800, guojiufu wrote: > PR target/61837 Wrong PR number? > +@deftypefn {Target Hook} machine_mode TARGET_PREFERRED_DOLOOP_MODE > (machine_mode @var{mode}) > +This hook takes a @var{mode} which is the original mode of doloop IV. > +And if the target

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-14 Thread guojiufu via Gcc-patches
On 2021-07-14 12:40, guojiufu via Gcc-patches wrote: Updated the patch as below: Thanks for comments. gcc/ChangeLog: 2021-07-13 Jiufu Guo PR target/61837 * config/rs6000/rs6000.c (TARGET_PREFERRED_DOLOOP_MODE): New hook. (rs6000_preferred_doloop_mode): New hook.

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-13 Thread guojiufu via Gcc-patches
On 2021-07-14 04:50, Segher Boessenkool wrote: Hi! On Tue, Jul 13, 2021 at 08:50:46PM +0800, Jiufu Guo wrote: * doc/tm.texi: Regenerated. Pet peeve: "Regenerate.", no "d". Ok, yeap. While, 'Regenerate and Regenerated' were used by commits somewhere :) +DEFHOOK

Re: [PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-13 Thread Segher Boessenkool
Hi! On Tue, Jul 13, 2021 at 08:50:46PM +0800, Jiufu Guo wrote: > * doc/tm.texi: Regenerated. Pet peeve: "Regenerate.", no "d". > +DEFHOOK > +(preferred_doloop_mode, > + "This hook returns a more preferred mode or the @var{mode} itself.", > + machine_mode, > + (machine_mode mode), > +

[PATCH V2] Use preferred mode for doloop iv [PR61837].

2021-07-13 Thread Jiufu Guo via Gcc-patches
Major changes from v1: * Add target hook to query preferred doloop mode. * Recompute doloop iv base from niter under preferred mode. Currently, doloop.xx variable is using the type as niter which may shorter than word size. For some cases, it would be better to use word size type. For example,