Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-03 Thread JunMa
在 2020/3/3 下午8:15, Nathan Sidwell 写道: On 3/3/20 12:42 AM, JunMa wrote: 在 2020/3/2 下午10:49, Nathan Sidwell 写道: On 2/12/20 2:23 AM, JunMa wrote: Hi nathan Here is the updated patch This is ok, with a correction in a comment: +  /* This isn't a temporary or argument.  */    /* This i

Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-03 Thread Nathan Sidwell
On 3/3/20 12:42 AM, JunMa wrote: 在 2020/3/2 下午10:49, Nathan Sidwell 写道: On 2/12/20 2:23 AM, JunMa wrote: Hi nathan Here is the updated patch This is ok, with a correction in a comment: + /* This isn't a temporary or argument. */ /* This isn't a temporary. */ is sufficient.

Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-02 Thread JunMa
在 2020/3/2 下午10:49, Nathan Sidwell 写道: On 2/12/20 2:23 AM, JunMa wrote: Hi In captures_temporary, the current implementation fails to handle component_ref. This causes ice with case co_await A while operator co_await is defined in base class of A. Also it is necessary to capture the object of ba

Re: [PATCH coroutines] Handle component_ref in captures_temporary

2020-03-02 Thread Nathan Sidwell
On 2/12/20 2:23 AM, JunMa wrote: Hi In captures_temporary, the current implementation fails to handle component_ref. This causes ice with case co_await A while operator co_await is defined in base class of A. Also it is necessary to capture the object of base class as if it is temporary object.

Re: [PING PATCH coroutines] Handle component_ref in captures_temporary

2020-02-26 Thread JunMa
在 2020/2/12 下午3:23, JunMa 写道: Kindly ping Regards JunMa Hi In captures_temporary, the current implementation fails to handle component_ref. This causes ice with case co_await A while operator co_await is defined in base class of A. Also it is necessary to capture the object of base class as if i

[PATCH coroutines] Handle component_ref in captures_temporary

2020-02-11 Thread JunMa
Hi In captures_temporary, the current implementation fails to handle component_ref. This causes ice with case co_await A while operator co_await is defined in base class of A. Also it is necessary to capture the object of base class as if it is temporary object. This patch strips component_ref to