Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Manuel López-Ibáñez lopeziba...@gmail.com writes: On 15 May 2015 at 10:39, Dodji Seketeli do...@redhat.com wrote: Manuel López-Ibáñez lopeziba...@gmail.com writes: -/* Expand the location of this diagnostic. Use this function for consistency. */ +/* Return the location associated to this

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Manuel López-Ibáñez lopeziba...@gmail.com writes: Thanks for the review. I followed all your suggestions. For the accessor functions, I was not sure what type you would prefer, so I implemented them as C++ methods and made use of 'private' to be sure they are the only way to access the

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

On 15 May 2015 at 10:39, Dodji Seketeli do...@redhat.com wrote: Manuel López-Ibáñez lopeziba...@gmail.com writes: -/* Expand the location of this diagnostic. Use this function for consistency. */ +/* Return the location associated to this diagnostic. WHICH specifies Here, I think only the

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Hi Dodji, Thanks for the review. I followed all your suggestions. For the accessor functions, I was not sure what type you would prefer, so I implemented them as C++ methods and made use of 'private' to be sure they are the only way to access the locations array. If you want me to change it, just

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Hello Manuel, Sorry for my late reply, and thank you very much for working on this. I have looked at the patch and I like it! I guess I just have some few lateral nits to pick. The Fortran FE allows diagnostics with two different locations. Depending on whether these locations are on the

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Dear all, Dodji: The gcc/*.[ch] part is your realm. David: I added you as CC because you looked into fancier diagnostics before Manuel López-Ibáñez wrote: The Fortran FE allows diagnostics with two different locations. [...] This is the last remaining issue Thanks for working on this - and

Re: [PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

Ping: https://gcc.gnu.org/ml/gcc-patches/2015-04/msg01093.html On 20 April 2015 at 22:00, Manuel López-Ibáñez lopeziba...@gmail.com wrote: The Fortran FE allows diagnostics with two different locations. Depending on whether these locations are on the same line or not, this may produce one or

[PATCH diagnostics/fortran] Handle two locations for the same diagnostic. Convert all gfc_warning_1 and gfc_notify_std_1 calls

The Fortran FE allows diagnostics with two different locations. Depending on whether these locations are on the same line or not, this may produce one or two caret lines. This is the last remaining issue left to make Fortran diagnostics use the common code. In the common diagnostics: I added