Hi Dodji,
On 23 October 2014 at 13:11, Dodji Seketeli wrote:
> /* If MAP is not the last line map of its set, then the new location
>(loc + offset) should be less than the first location encoded by
>the next line map of the set. */
which is currently implemented as:
if (map
On 11 November 2014 17:10, Jason Merrill wrote:
> On 10/31/2014 10:01 PM, Manuel López-Ibáñez wrote:
>>
>> +sense. So let's live the location intact in that case. */
>
>
> s/live/leave/
>
>> + /* If MAP is not the last line map of its set, then the new location
>> + (loc + offset) s
On 10/31/2014 10:01 PM, Manuel López-Ibáñez wrote:
+sense. So let's live the location intact in that case. */
s/live/leave/
+ /* If MAP is not the last line map of its set, then the new location
+ (loc + offset) should be less than the first location encoded by
+ the next l
Dear Jason or Tom,
Only the libcpp parts are pending review.
This is an updated version of
https://gcc.gnu.org/ml/gcc-patches/2014-10/msg01621.html
The only changes are more uses of gfc_warning_now_2 to increase
testing, which required updating gfortran.dg/warnings_are_errors_1.f,
and implementi
On 23 October 2014 21:10, Dodji Seketeli wrote:
> Sorry, I forgot to make it clear that I have no power to approve the
> line-map changes. I just gave my casual point view; so please take it
> for what it is worth.
>
> I am CC-ing Tom and Jason who can approve this.
I don't see the CCs in the co
Hi Manuel,
Dodji Seketeli wrote:
Sorry, I forgot to make it clear that I have no power to approve the
line-map changes. I just gave my casual point view; so please take it
for what it is worth.
I am CC-ing Tom and Jason who can approve this.
And I have a minor nit, which I forgot in my origi
Sorry, I forgot to make it clear that I have no power to approve the
line-map changes. I just gave my casual point view; so please take it
for what it is worth.
I am CC-ing Tom and Jason who can approve this.
Cheers.
Dodji Seketeli writes:
> Hello Manuel,
>
> Manuel López-Ibáñez writes:
>
>
Hello Manuel,
Manuel López-Ibáñez writes:
> Dodji, are the linemap_asserts() appropriate?
Yes they are. I have some additional comments though.
> libcpp/ChangeLog:
>
> 2014-10-16 Manuel López-Ibáñez
>
> PR fortran/44054
> * include/line-map.h (linemap_position_for_loc_and_offset):
Manuel López-Ibáñez wrote:
This patch adds handling of Fortran %C using the common diagnostics
machinery. This is achieved by dynamically generating a location given
a location and an offset. This only works for non-macro line-maps (for
now), but this is OK since Fortran does not have virtual loc
This patch adds handling of Fortran %C using the common diagnostics
machinery. This is achieved by dynamically generating a location given
a location and an offset. This only works for non-macro line-maps (for
now), but this is OK since Fortran does not have virtual locations
(and I'm afraid it won
10 matches
Mail list logo
