Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-04 Thread Tobias Burnus
Hi Manuel, thanks for rightfully nagging - I shouldn't do late at night reviews. Regarding: Manuel López-Ibáñez wrote: It is still not clear to me if line_len is the length of the line read or not, is it? If not, is there any way to actually get the length of the line? Looking at the code in

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-04 Thread Manuel López-Ibáñez
On 4 December 2014 at 11:21, Tobias Burnus tobias.bur...@physik.fu-berlin.de wrote: Manuel López-Ibáñez wrote: It is still not clear to me if line_len is the length of the line read or not, is it? If not, is there any way to actually get the length of the line? Looking at the code in

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-03 Thread Tobias Burnus
Manuel López-Ibáñez wrote: In any case, the current patch fixes these ICEs and I couldn't trigger new ones. Bootstrapped and regression tested. OK for Fortran? OK. Thanks. * * * BTW: The output of the code changes with the common diagnostic. For a different test case, I get (old)

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-03 Thread Manuel López-Ibáñez
On 4 December 2014 at 00:25, Tobias Burnus bur...@net-b.de wrote: Manuel López-Ibáñez wrote: In any case, the current patch fixes these ICEs and I couldn't trigger new ones. Bootstrapped and regression tested. OK for Fortran? OK. Thanks. It is still not clear to me if line_len is the

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-02 Thread Manuel López-Ibáñez
On 2 December 2014 at 07:50, Tobias Burnus bur...@net-b.de wrote: Hi Manuel, Manuel López-Ibáñez wrote: This patch actually does not touch linemap but I will appreciate Dodji's comments about the approach. The problem is that in case of long lines, the column hint of 120 might be too small,

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-02 Thread Dodji Seketeli
Hello Manuel, Tobias, Manuel López-Ibáñez lopeziba...@gmail.com writes: This patch actually does not touch linemap but I will appreciate Dodji's comments about the approach. Thanks :-) The problem is that in case of long lines, the column hint of 120 might be too small, thus we do not have

[PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-01 Thread Manuel López-Ibáñez
This patch actually does not touch linemap but I will appreciate Dodji's comments about the approach. The problem is that in case of long lines, the column hint of 120 might be too small, thus we do not have enough locations within one line to point to a higher column (like 132 in the testcase).

Re: [PATCH fortran/linemap] Add enough column hint to fit any possible offset

2014-12-01 Thread Tobias Burnus
Hi Manuel, Manuel López-Ibáñez wrote: This patch actually does not touch linemap but I will appreciate Dodji's comments about the approach. The problem is that in case of long lines, the column hint of 120 might be too small, thus we do not have enough locations within one line to point to a