Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-07 Thread Jonathan Yong
On 6/6/24 09:23, Evgeny Karpov wrote: Thursday, June 6, 2024 1:42 AM Jonathan Yong <10wa...@gmail.com> wrote: Where is HAVE_64BIT_POINTERS used? Sorry, it was missed in the posted changes for review. Regards, Evgeny diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-06 Thread Evgeny Karpov
Thursday, June 6, 2024 1:42 AM Jonathan Yong <10wa...@gmail.com> wrote: > > Where is HAVE_64BIT_POINTERS used? > Sorry, it was missed in the posted changes for review. Regards, Evgeny diff --git a/gcc/config/mingw/mingw32.h b/gcc/config/mingw/mingw32.h index 8a6f0e8e8a5..0c9d5424942 100644 ---

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-05 Thread Jonathan Yong
On 6/5/24 06:01, Uros Bizjak wrote: On Tue, Jun 4, 2024 at 10:10 PM Evgeny Karpov wrote: Richard and Uros, could you please review the changes for v2? LGTM for the generic x86 part, OS-specific part (cygming) should also be reviewed by OS port maintainer (CC'd). Thanks, Uros. Where is

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-05 Thread Richard Sandiford
Evgeny Karpov writes: > Richard and Uros, could you please review the changes for v2? > Additionally, we have detected an issue with GCC GC in winnt-dll.cc. The fix > will be included in v2. Would it be possible to have a more "purposeful" name than CMODEL_IS_NOT_LARGE_OR_MEDIUM_PIC? What's

Re: [PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-05 Thread Uros Bizjak
On Tue, Jun 4, 2024 at 10:10 PM Evgeny Karpov wrote: > > Richard and Uros, could you please review the changes for v2? LGTM for the generic x86 part, OS-specific part (cygming) should also be reviewed by OS port maintainer (CC'd). Thanks, Uros. > Additionally, we have detected an issue with

[PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-06-04 Thread Evgeny Karpov
Richard and Uros, could you please review the changes for v2? Additionally, we have detected an issue with GCC GC in winnt-dll.cc. The fix will be included in v2. >> -ix86_handle_selectany_attribute (tree *node, tree name, tree, int, >> +mingw_handle_selectany_attribute (tree *node, tree name,

[PATCH v1 0/6] Add DLL import/export implementation to AArch64

2024-04-18 Thread Evgeny Karpov
Hello, This is the second patch series, following the first patch series which introduced the aarch64-w64-mingw32 target. https://gcc.gnu.org/pipermail/gcc-patches/2024-February/thread.html#646203 https://gcc.gnu.org/pipermail/gcc-patches/2024-March/thread.html#647128