Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-03-01 Thread Maxim Kuvyrkov
ki (QUIC) >>> Cc: Evgeny Karpov ; Andrew Pinski >>> ; Richard Sandiford ; gcc- >>> patc...@gcc.gnu.org; 10wa...@gmail.com; m...@harmstone.com; Zac >>> Walker ; Ron Riddle >>> ; Radek Barton >>> Subject: Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW

[PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Evgeny Karpov
Thursday, February 29, 2024 6:56 PM Andrew Pinski (QUIC) wrote: > Looking at these results, this port is not in any shape or form to be > upstreamed > right now. Even simple -g will cause failures. > Note we don't need a clean testsuite run but the patch series is not even > allowing enabling hel

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Richard Earnshaw (lists)
patc...@gcc.gnu.org; 10wa...@gmail.com; m...@harmstone.com; Zac >> Walker ; Ron Riddle >> ; Radek Barton >> Subject: Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW >> environments for AArch64 >> >> WARNING: This email originated from outside of Qualcomm. Please be w

RE: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Andrew Pinski (QUIC)
Riddle > ; Radek Barton > Subject: Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW > environments for AArch64 > > WARNING: This email originated from outside of Qualcomm. Please be wary > of any links or attachments, and do not enable macros. > > > On Fe

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Maxim Kuvyrkov
c.gnu.org; 10wa...@gmail.com; Maxim Kuvyrkov >> ; m...@harmstone.com; Zac Walker >> ; Ron Riddle ; Radek >> Barton ; Andrew Pinski (QUIC) >> >> Subject: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments >> for AArch64 >> >> Wednesday, February 28,

RE: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Andrew Pinski (QUIC)
arton ; Andrew Pinski (QUIC) > > Subject: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments > for AArch64 > > Wednesday, February 28, 2024 2:00 AM > Andrew Pinski wrote: > > > What does this mean with respect to C++ exceptions? Or you using SJLJ > > except

[PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-29 Thread Evgeny Karpov
Wednesday, February 28, 2024 2:00 AM Andrew Pinski wrote: > What does this mean with respect to C++ exceptions? Or you using SJLJ > exceptions support or the dwarf unwinding ones without SEH support? > I am not sure if SJLJ exceptions is well tested any more in GCC either. > > Also I have a quest

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-27 Thread NightStrike
> -Original Message- > Friday, February 23, 2024 6:16 PM > Richard Sandiford wrote: > > > + > > +#undef TARGET_SEH > > +#define TARGET_SEH 0 > > + > > +#define SSE_REGNO_P(N) 0 > > +#define GENERAL_REGNO_P(N) 0 > > Could you add a comment to explain how these two macros are consumed? > What

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-27 Thread Andrew Pinski
On Tue, Feb 27, 2024 at 1:18 PM Evgeny Karpov wrote: > > SEH is not implemented yet and needs to be disabled in mingw/winnt.cc. > Disabling every SEH function that uses references to these macros might > trigger significant refactoring, and to avoid this, required macros are > defined with 0. I

[PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-27 Thread Evgeny Karpov
SEH is not implemented yet and needs to be disabled in mingw/winnt.cc. Disabling every SEH function that uses references to these macros might trigger significant refactoring, and to avoid this, required macros are defined with 0. It is needed only for compilation. A comment with an explanation

[PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-25 Thread Evgeny Karpov
Thank you for the historical information regarding the introduction of the features. I can confirm that removing the HAVE_GAS_WEAK check and setting HAVE_GAS_ALIGNED_COMM to 1 by default works well. These changes will be included in v2. Regards, Evgeny -Original Message- Thursday, Febru

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-23 Thread Richard Sandiford
Evgeny Karpov writes: > From 1ea6efa6f88d131884ecef21c4b5d2ecbab14ea7 Mon Sep 17 00:00:00 2001 > From: Zac Walker > Date: Tue, 20 Feb 2024 18:06:36 +0100 > Subject: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for > AArch64 > > Define Cygwin and MinGW envi

Re: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-22 Thread Richard Earnshaw (lists)
On 21/02/2024 18:36, Evgeny Karpov wrote: > +/* GNU as supports weak symbols on PECOFF. */ +#ifdef HAVE_GAS_WEAK Can't we assume this is true? It was most likely needed on i386 because support goes back longer than the assembler had this feature, but it looks like it was added in 2000, or the

[PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64

2024-02-21 Thread Evgeny Karpov
From 1ea6efa6f88d131884ecef21c4b5d2ecbab14ea7 Mon Sep 17 00:00:00 2001 From: Zac Walker Date: Tue, 20 Feb 2024 18:06:36 +0100 Subject: [PATCH v1 08/13] aarch64: Add Cygwin and MinGW environments for AArch64 Define Cygwin and MinGW environment such as types, SEH definitions, shared libraries