Re: [PATCH v1 3/4] aarch64: improve assembly debug comments for build attributes

2024-10-17 Thread Richard Sandiford
Matthieu Longo writes: > On 2024-10-08 18:45, Richard Sandiford wrote: >> However... >> >>> + return s; >> >> ...we are unfortunately limited to C++11 constexprs, so I think this needs >> to be: >> >>return (t == uleb128 ? "ULEB128" >>: t == asciz ? "asciz" >>: null

Re: [PATCH v1 3/4] aarch64: improve assembly debug comments for build attributes

2024-10-16 Thread Matthieu Longo
On 2024-10-08 18:45, Richard Sandiford wrote: Matthieu Longo writes: The previous implementation to emit build attributes did not support string values (asciz) in aeabi_subsection, and was not emitting values associated to tags in the assembly comments. This new approach provides a more user-f

Re: [PATCH v1 3/4] aarch64: improve assembly debug comments for build attributes

2024-10-08 Thread Richard Sandiford
Matthieu Longo writes: > The previous implementation to emit build attributes did not support > string values (asciz) in aeabi_subsection, and was not emitting values > associated to tags in the assembly comments. > > This new approach provides a more user-friendly interface relying on > typing, a

[PATCH v1 3/4] aarch64: improve assembly debug comments for build attributes

2024-09-27 Thread Matthieu Longo
The previous implementation to emit build attributes did not support string values (asciz) in aeabi_subsection, and was not emitting values associated to tags in the assembly comments. This new approach provides a more user-friendly interface relying on typing, and improves the emitted assembly co