Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On Thu, May 2, 2024 at 9:45 AM Jason Merrill wrote: > > On 5/2/24 12:20, Ken Matsui wrote: > > On Thu, May 2, 2024 at 8:34 AM Ken Matsui wrote: > >> > >> On Thu, May 2, 2024 at 8:16 AM Patrick Palka wrote: > >>> > >>> On Tue, 30 Apr 2024, Jason Merrill wrote: > >>> > On 2/28/24 11:26, Ken

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On 5/2/24 12:20, Ken Matsui wrote: On Thu, May 2, 2024 at 8:34 AM Ken Matsui wrote: On Thu, May 2, 2024 at 8:16 AM Patrick Palka wrote: On Tue, 30 Apr 2024, Jason Merrill wrote: On 2/28/24 11:26, Ken Matsui wrote: This patch implements built-in trait for std::rank. __rank seems too

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On Thu, May 2, 2024 at 8:34 AM Ken Matsui wrote: > > On Thu, May 2, 2024 at 8:16 AM Patrick Palka wrote: > > > > On Tue, 30 Apr 2024, Jason Merrill wrote: > > > > > On 2/28/24 11:26, Ken Matsui wrote: > > > > This patch implements built-in trait for std::rank. > > > > > > __rank seems too short,

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On Thu, May 2, 2024 at 8:16 AM Patrick Palka wrote: > > On Tue, 30 Apr 2024, Jason Merrill wrote: > > > On 2/28/24 11:26, Ken Matsui wrote: > > > This patch implements built-in trait for std::rank. > > > > __rank seems too short, maybe __array_rank? > > > > Actually, it occurs to me that perhaps

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On Tue, 30 Apr 2024, Jason Merrill wrote: > On 2/28/24 11:26, Ken Matsui wrote: > > This patch implements built-in trait for std::rank. > > __rank seems too short, maybe __array_rank? > > Actually, it occurs to me that perhaps we should have been adding __builtin to > all of these rather than

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On Tue, Apr 30, 2024 at 2:08 PM Jason Merrill wrote: > > On 2/28/24 11:26, Ken Matsui wrote: > > This patch implements built-in trait for std::rank. > > __rank seems too short, maybe __array_rank? > > Actually, it occurs to me that perhaps we should have been adding > __builtin to all of these

Re: [PATCH v14 21/26] c++: Implement __rank built-in trait

On 2/28/24 11:26, Ken Matsui wrote: This patch implements built-in trait for std::rank. __rank seems too short, maybe __array_rank? Actually, it occurs to me that perhaps we should have been adding __builtin to all of these rather than just __ and the library trait name. I guess it's too

[PATCH v14 21/26] c++: Implement __rank built-in trait

This patch implements built-in trait for std::rank. gcc/cp/ChangeLog: * cp-trait.def: Define __rank. * constraint.cc (diagnose_trait_expr): Handle CPTK_RANK. * semantics.cc (trait_expr_value): Likewise. (finish_trait_expr): Likewise. gcc/testsuite/ChangeLog: