Re: [PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-10 Thread Kewen.Lin via Gcc-patches
on 2022/8/10 05:34, Segher Boessenkool wrote: > On Tue, Aug 09, 2022 at 11:14:16AM +0800, Kewen.Lin wrote: >> on 2022/8/8 14:04, HAO CHEN GUI wrote: >>> +/* { dg-do run { target { has_arch_ppc64 } } } */ >>> +/* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */ >>> +/* { dg-require-effective

Re: [PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-09 Thread HAO CHEN GUI via Gcc-patches
Hi Segher, Thanks for your comments. I checked the cost table. For P9 and P10, the cost of all mul* insn is the same, not relevant to the size of operand. I will split the test case to one compiling and one runnable case. Thanks. Gui Haochen On 10/8/2022 上午 5:43, Segher Boessenkool wrote: >

Re: [PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-09 Thread Segher Boessenkool
Hi! On Mon, Aug 08, 2022 at 02:04:07PM +0800, HAO CHEN GUI wrote: > This patch adds an expand and several insns for multiply-add with three > 64bit operands. Also for maddld for 32-bit operands. >"maddld %0,%1,%2,%3" >[(set_attr "type" "mul")]) I suppose attr "size" isn't relevant for

Re: [PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-09 Thread Segher Boessenkool
On Tue, Aug 09, 2022 at 11:14:16AM +0800, Kewen.Lin wrote: > on 2022/8/8 14:04, HAO CHEN GUI wrote: > > +/* { dg-do run { target { has_arch_ppc64 } } } */ > > +/* { dg-options "-O2 -mdejagnu-cpu=power9 -save-temps" } */ > > +/* { dg-require-effective-target int128 } */ > > +/* { dg-require-effectiv

Re: [PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-08 Thread Kewen.Lin via Gcc-patches
Hi Haochen, Thanks for the patch. on 2022/8/8 14:04, HAO CHEN GUI wrote: > Hi, > This patch adds an expand and several insns for multiply-add with three > 64bit operands. > > Compared with last version, the main changes are: > 1 The "maddld" pattern is reused for the low-part generation. > 2

[PATCH v2, rs6000] Add multiply-add expand pattern [PR103109]

2022-08-07 Thread HAO CHEN GUI via Gcc-patches
Hi, This patch adds an expand and several insns for multiply-add with three 64bit operands. Compared with last version, the main changes are: 1 The "maddld" pattern is reused for the low-part generation. 2 A runnable testcase replaces the original compiling case. 3 Fixes indention problems.