Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-13 Thread Iain Sandoe via Gcc-patches
Hi > On 13 Sep 2022, at 03:34, HAO CHEN GUI via Gcc-patches > wrote: > On 7/9/2022 上午 1:19, Segher Boessenkool wrote: >> make -k -j60 check >> RUNTESTFLAGS="--target_board=unix'{-m64,-m32,-m32/-mpowerpc64}'" >> >> It is fine to not test -m32/-mpowerpc64 so often, and certaionly not >> someth

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-12 Thread HAO CHEN GUI via Gcc-patches
Hi Segher, On 7/9/2022 上午 1:19, Segher Boessenkool wrote: > make -k -j60 check > RUNTESTFLAGS="--target_board=unix'{-m64,-m32,-m32/-mpowerpc64}'" > > It is fine to not test -m32/-mpowerpc64 so often, and certaionly not > something I will ask everyone to always do :-) IMO, if we add "-mpowerpc64

RE: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-12 Thread HAO CHEN GUI via Gcc-patches
Hi Segher, On 10/9/2022 上午 1:17, Segher Boessenkool wrote: >> In rs6000-overload.def, the vsx_ version built-ins are overridden to vec_ >> version. > How? Where? vec_ version built-ins are defined in rs6000-overload.def. Yes, they're fine and in line with the definition in PVIPR. [VEC_VEEDP,

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-09 Thread Segher Boessenkool
On Thu, Sep 08, 2022 at 01:59:02PM +0800, HAO CHEN GUI wrote: > In rs6000-overload.def, the vsx_ version built-ins are overridden to vec_ > version. How? Where? Instead, afaics they are defined in rs6000-builtins.def: const vd __builtin_vsx_extract_exp_dp (vd); VEEDP xvxexpdp {} const

RE: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-07 Thread HAO CHEN GUI via Gcc-patches
On 7/9/2022 下午 10:25, Segher Boessenkool wrote: > Hi! > > On Wed, Sep 07, 2022 at 08:51:17AM -0500, Paul A. Clarke wrote: >> On Tue, Sep 06, 2022 at 12:19:06PM -0500, Segher Boessenkool wrote: >>> On Mon, Sep 05, 2022 at 02:36:30PM +0800, HAO CHEN GUI wrote: The return type of vec_ version

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-07 Thread Segher Boessenkool
Hi! On Wed, Sep 07, 2022 at 08:51:17AM -0500, Paul A. Clarke wrote: > On Tue, Sep 06, 2022 at 12:19:06PM -0500, Segher Boessenkool wrote: > > On Mon, Sep 05, 2022 at 02:36:30PM +0800, HAO CHEN GUI wrote: > > > The return type of vec_ version built-ins are different than their > > > definition > >

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-07 Thread Paul A. Clarke via Gcc-patches
On Tue, Sep 06, 2022 at 12:19:06PM -0500, Segher Boessenkool wrote: > On Mon, Sep 05, 2022 at 02:36:30PM +0800, HAO CHEN GUI wrote: > > On 2/9/2022 下午 11:56, Segher Boessenkool wrote: > > >> - const signed long __builtin_vsx_scalar_extract_exp (double); > > >> + const unsigned long long __builtin

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-06 Thread Segher Boessenkool
Hi! On Mon, Sep 05, 2022 at 02:36:30PM +0800, HAO CHEN GUI wrote: > On 2/9/2022 下午 11:56, Segher Boessenkool wrote: > >> - const signed long __builtin_vsx_scalar_extract_exp (double); > >> + const unsigned long long __builtin_vsx_scalar_extract_exp (double); > >> VSEEDP xsxexpdp {} > >> > >

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-04 Thread HAO CHEN GUI via Gcc-patches
Hi Segher, Thanks for your review comments. On 2/9/2022 下午 11:56, Segher Boessenkool wrote: >> - const signed long __builtin_vsx_scalar_extract_exp (double); >> + const unsigned long long __builtin_vsx_scalar_extract_exp (double); >> VSEEDP xsxexpdp {} >> >> - const signed long __builtin

Re: [PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-02 Thread Segher Boessenkool
Hi! On Fri, Sep 02, 2022 at 04:31:38PM +0800, HAO CHEN GUI wrote: > This patch is for internal issue1136. This isn't useful to most people. Either just don't mention it here, or make a public PR for it if that is useful? > It changes insn condition from > TARGET_64BIT to TARGET_POWERPC64 for

[PATCH v2, rs6000] Change insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions

2022-09-02 Thread HAO CHEN GUI via Gcc-patches
Hi, This patch is for internal issue1136. It changes insn condition from TARGET_64BIT to TARGET_POWERPC64 for VSX scalar extract/insert instructions. These instructions all use DI registers and can be invoked with -mpowerpc64 in a 32-bit environment. This patch also changes prototypes of rela