Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-10-02 Thread Richard Sandiford
Andrew Pinski andrew.pin...@caviumnetworks.com writes: On Thu, Sep 27, 2012 at 11:13 AM, Uros Bizjak ubiz...@gmail.com wrote: 2012-09-27 Uros Bizjak ubiz...@gmail.com PR rtl-optimization/54457 * simplify-rtx.c (simplify_subreg): Simplify (subreg:M (op:N ((x:N)

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-10-01 Thread Andrew Pinski
On Thu, Sep 27, 2012 at 11:13 AM, Uros Bizjak ubiz...@gmail.com wrote: On Thu, Sep 27, 2012 at 8:08 PM, paul_kon...@dell.com wrote: I agree (subreg:M (op:N A C) 0) to (op:M (subreg:N (A 0)) C) is a good transformation, but why do we need to handle as special the case where the subreg is

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-30 Thread Richard Sandiford
Uros Bizjak ubiz...@gmail.com writes: On Thu, Sep 27, 2012 at 8:20 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Sep 27, 2012 at 08:04:58PM +0200, Uros Bizjak wrote: After some off-line discussion with Richard, attached is v2 of the patch. 2012-09-27 Uros Bizjak ubiz...@gmail.com

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-28 Thread Uros Bizjak
On Thu, Sep 27, 2012 at 8:20 PM, Jakub Jelinek ja...@redhat.com wrote: On Thu, Sep 27, 2012 at 08:04:58PM +0200, Uros Bizjak wrote: After some off-line discussion with Richard, attached is v2 of the patch. 2012-09-27 Uros Bizjak ubiz...@gmail.com PR rtl-optimization/54457

[PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-27 Thread Uros Bizjak
On Thu, Sep 27, 2012 at 4:25 PM, Richard Sandiford rdsandif...@googlemail.com wrote: I agree (subreg:M (op:N A C) 0) to (op:M (subreg:N (A 0)) C) is a good transformation, but why do we need to handle as special the case where the subreg is itself the operand of a plus or minus? I think it

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-27 Thread Paul_Koning
On Sep 27, 2012, at 2:04 PM, Uros Bizjak wrote: I agree (subreg:M (op:N A C) 0) to (op:M (subreg:N (A 0)) C) is a good transformation, but why do we need to handle as special the case where the subreg is itself the operand of a plus or minus? I think it should happen regardless of

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-27 Thread Uros Bizjak
On Thu, Sep 27, 2012 at 8:08 PM, paul_kon...@dell.com wrote: I agree (subreg:M (op:N A C) 0) to (op:M (subreg:N (A 0)) C) is a good transformation, but why do we need to handle as special the case where the subreg is itself the operand of a plus or minus? I think it should happen regardless

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-27 Thread Jakub Jelinek
On Thu, Sep 27, 2012 at 08:04:58PM +0200, Uros Bizjak wrote: After some off-line discussion with Richard, attached is v2 of the patch. 2012-09-27 Uros Bizjak ubiz...@gmail.com PR rtl-optimization/54457 * simplify-rtx.c (simplify_subreg): Simplify (subreg:SI (op:DI

Re: [PATCH v2, rtl-optimization]: Fix PR54457, [x32] Fail to combine 64bit index + constant

2012-09-27 Thread Richard Sandiford
Jakub Jelinek ja...@redhat.com writes: On Thu, Sep 27, 2012 at 08:04:58PM +0200, Uros Bizjak wrote: After some off-line discussion with Richard, attached is v2 of the patch. 2012-09-27 Uros Bizjak ubiz...@gmail.com PR rtl-optimization/54457 * simplify-rtx.c