Re: [PATCH v2][RFC] Canonize names of attributes.

2017-08-04 Thread Jason Merrill
On Fri, Aug 4, 2017 at 9:42 AM, Martin Liška wrote: > On 08/02/2017 01:25 PM, Joseph Myers wrote: >> On Thu, 13 Jul 2017, Martin Liška wrote: >> >>> +/* For a given IDENTIFIER_NODE, strip leading and trailing '_' characters >>> + so that we have a canonical form of attribute names. */ >>> + >>>

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-08-04 Thread Martin Liška
On 08/02/2017 01:25 PM, Joseph Myers wrote: > On Thu, 13 Jul 2017, Martin Liška wrote: > >> +/* For a given IDENTIFIER_NODE, strip leading and trailing '_' characters >> + so that we have a canonical form of attribute names. */ >> + >> +static inline tree >> +canonicalize_attr_name (tree attr_n

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-08-02 Thread Jason Merrill
OK. On Thu, Jul 13, 2017 at 9:48 AM, Martin Liška wrote: > On 07/11/2017 05:52 PM, Jason Merrill wrote: >> On Tue, Jul 11, 2017 at 9:37 AM, Martin Liška wrote: >>> On 07/03/2017 11:00 PM, Jason Merrill wrote: On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: > On 06/30/2017 09:34 PM,

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-08-02 Thread Joseph Myers
On Thu, 13 Jul 2017, Martin Liška wrote: > +/* For a given IDENTIFIER_NODE, strip leading and trailing '_' characters > + so that we have a canonical form of attribute names. */ > + > +static inline tree > +canonicalize_attr_name (tree attr_name) > +{ > + const size_t l = IDENTIFIER_LENGTH (at

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-27 Thread Martin Liška
PING^1 On 07/13/2017 03:48 PM, Martin Liška wrote: > On 07/11/2017 05:52 PM, Jason Merrill wrote: >> On Tue, Jul 11, 2017 at 9:37 AM, Martin Liška wrote: >>> On 07/03/2017 11:00 PM, Jason Merrill wrote: On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: > On 06/30/2017 09:34 PM, Jason

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-13 Thread Martin Liška
On 07/11/2017 05:52 PM, Jason Merrill wrote: > On Tue, Jul 11, 2017 at 9:37 AM, Martin Liška wrote: >> On 07/03/2017 11:00 PM, Jason Merrill wrote: >>> On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: On 06/30/2017 09:34 PM, Jason Merrill wrote: > > On Fri, Jun 30, 2017 at 5:23 AM

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-11 Thread Jason Merrill
On Tue, Jul 11, 2017 at 9:37 AM, Martin Liška wrote: > On 07/03/2017 11:00 PM, Jason Merrill wrote: >> On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: >>> On 06/30/2017 09:34 PM, Jason Merrill wrote: On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška wrote: > > This is v2 of the

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-11 Thread Martin Liška
On 07/03/2017 11:00 PM, Jason Merrill wrote: On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: On 06/30/2017 09:34 PM, Jason Merrill wrote: On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška wrote: This is v2 of the patch, where just names of attributes are canonicalized. Patch can bootstrap on

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-03 Thread Jason Merrill
On Mon, Jul 3, 2017 at 5:52 AM, Martin Liška wrote: > On 06/30/2017 09:34 PM, Jason Merrill wrote: >> On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška wrote: >>> This is v2 of the patch, where just names of attributes are canonicalized. >>> Patch can bootstrap on ppc64le-redhat-linux and survives re

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-07-03 Thread Martin Liška
On 06/30/2017 09:34 PM, Jason Merrill wrote: > On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška wrote: >> This is v2 of the patch, where just names of attributes are canonicalized. >> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. > > What is the purpose of the new "stric

Re: [PATCH v2][RFC] Canonize names of attributes.

2017-06-30 Thread Jason Merrill
On Fri, Jun 30, 2017 at 5:23 AM, Martin Liška wrote: > This is v2 of the patch, where just names of attributes are canonicalized. > Patch can bootstrap on ppc64le-redhat-linux and survives regression tests. What is the purpose of the new "strict" parameter to cmp_attribs* ? I don't see any discu

[PATCH v2][RFC] Canonize names of attributes.

2017-06-30 Thread Martin Liška
On 06/28/2017 09:01 PM, Jason Merrill wrote: > On Wed, Jun 28, 2017 at 12:05 PM, Joseph Myers > wrote: >> On Wed, 28 Jun 2017, Martin Liška wrote: >> >>> On 06/14/2017 07:24 PM, Jason Merrill wrote: On Tue, Jun 13, 2017 at 8:32 AM, Martin Liška wrote: > (canonize_attr_name): New