Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-21 Thread Sören Tempel via Gcc-patches
"H.J. Lu" wrote: > OPTION_GLIBC can't be used here since OPTION_GLIBC is > evaluated at run-time: > > https://gcc.gnu.org/pipermail/gcc-regression/2022-January/076271.html Oops, my bad, sorry! This accidentally broke in one of the two cleanup commits. Originally I justed use TARGET_GLIBC_MAJOR

Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-21 Thread H.J. Lu via Gcc-patches
On Sat, Dec 18, 2021 at 4:20 AM soeren--- via Gcc-patches wrote: > > From: Sören Tempel > > The -fsplit-stack option requires the pthread_t TCB definition in the > libc to provide certain struct fields at specific hardcoded offsets. As > far as I know, only glibc provides these fields at the

Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-21 Thread Uros Bizjak via Gcc-patches
On Thu, Jan 20, 2022 at 11:52 PM Richard Sandiford wrote: > > cc:ing the x86 and s390 maintainers > > soeren--- via Gcc-patches writes: > > From: Sören Tempel > > > > The -fsplit-stack option requires the pthread_t TCB definition in the > > libc to provide certain struct fields at specific

Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-20 Thread Andreas Krebbel via Gcc-patches
On 1/20/22 23:52, Richard Sandiford wrote: > cc:ing the x86 and s390 maintainers > > soeren--- via Gcc-patches writes: >> From: Sören Tempel >> >> The -fsplit-stack option requires the pthread_t TCB definition in the >> libc to provide certain struct fields at specific hardcoded offsets. As >>

Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-20 Thread Richard Sandiford via Gcc-patches
cc:ing the x86 and s390 maintainers soeren--- via Gcc-patches writes: > From: Sören Tempel > > The -fsplit-stack option requires the pthread_t TCB definition in the > libc to provide certain struct fields at specific hardcoded offsets. As > far as I know, only glibc provides these fields at the

Re: Re: [PATCH v2] Disable -fsplit-stack support on non-glibc targets

2022-01-20 Thread Sören Tempel via Gcc-patches
Ping. Summary: Patch disable -fstack-split on non-glibc targets to prevent corruptions of the TCB on libcs which do not support the required fields in pthread_t. This is an important fix for having gccgo work on musl by default. See:

[PATCH v2] Disable -fsplit-stack support on non-glibc targets

2021-12-18 Thread soeren--- via Gcc-patches
From: Sören Tempel The -fsplit-stack option requires the pthread_t TCB definition in the libc to provide certain struct fields at specific hardcoded offsets. As far as I know, only glibc provides these fields at the required offsets. Most notably, musl libc does not have these fields. However,