Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-25 Thread Christophe Lyon via Gcc-patches
On Tue, 24 Nov 2020 at 19:43, Ulrich Weigand via Gcc-patches wrote: > > On Fri, Nov 20, 2020 at 09:33:48PM -0700, Jeff Law wrote: > > > * doc/invoke.texi (-ffast-math): Remove mention of > > > -fno-signaling-nans. > > > Clarify conditions when __FAST_MATH__ preprocessor macro is defined.

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-24 Thread Segher Boessenkool
Hi Ulrich, On Tue, Nov 24, 2020 at 07:42:47PM +0100, Ulrich Weigand wrote: > This did handle flag_excess_precision incorrectly, causing in particular > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97970 > > I've reverted for now and will post a modified patch later. > Sorry for the breakage! > >

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-24 Thread Ulrich Weigand via Gcc-patches
On Fri, Nov 20, 2020 at 09:33:48PM -0700, Jeff Law wrote: > > * doc/invoke.texi (-ffast-math): Remove mention of -fno-signaling-nans. > > Clarify conditions when __FAST_MATH__ preprocessor macro is defined. > > > > * opts.c (common_handle_option): Pass OPTS_SET to set_fast_math_flags >

Re: [wwwdocs] Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-24 Thread Segher Boessenkool
Hi! On Tue, Nov 24, 2020 at 11:55:23AM +0100, Ulrich Weigand wrote: > On Sat, Nov 21, 2020 at 01:57:32PM -0600, Segher Boessenkool wrote: > > It all makes sense, and is a nice improvement :-) But please mention it > > in the release notes? No doubt people did use non-sensical flag > > combinatio

[wwwdocs] Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-24 Thread Ulrich Weigand via Gcc-patches
On Sat, Nov 21, 2020 at 01:57:32PM -0600, Segher Boessenkool wrote: > On Fri, Nov 20, 2020 at 09:33:48PM -0700, Jeff Law wrote: > > On 2/11/20 11:43 AM, Ulrich Weigand wrote: > > > 1. If a component flag of -ffast-math (or -funsafe-math-optimizations) > > >is explicitly set (or reset) on the co

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-21 Thread Segher Boessenkool
Hi! On Fri, Nov 20, 2020 at 09:33:48PM -0700, Jeff Law wrote: > On 2/11/20 11:43 AM, Ulrich Weigand wrote: > > 1. If a component flag of -ffast-math (or -funsafe-math-optimizations) > >is explicitly set (or reset) on the command line, this should override > >any implicit change due to -f(n

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-11-20 Thread Jeff Law via Gcc-patches
On 2/11/20 11:43 AM, Ulrich Weigand wrote: > Hello, > > this second version of the patch incorporates all changes discussed > in the original mail thread starting here: > https://gcc.gnu.org/ml/gcc-patches/2020-01/msg02097.html > > The patch now implements the following set of changes: > > 1. If

Re: [PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-02-11 Thread Segher Boessenkool
Hi! On Tue, Feb 11, 2020 at 07:43:31PM +0100, Ulrich Weigand wrote: > 1. If a component flag of -ffast-math (or -funsafe-math-optimizations) >is explicitly set (or reset) on the command line, this should override >any implicit change due to -f(no-)fast-math, no matter in which order >t

[PATCH v2] Fix -ffast-math flags handling inconsistencies

2020-02-11 Thread Ulrich Weigand
Hello, this second version of the patch incorporates all changes discussed in the original mail thread starting here: https://gcc.gnu.org/ml/gcc-patches/2020-01/msg02097.html The patch now implements the following set of changes: 1. If a component flag of -ffast-math (or -funsafe-math-optimizati