Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 10:11 AM Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 09:39:12AM -0800, H.J. Lu wrote: > > GNU binutils has no issues with it: > > I know, I meant gcc. > If I try the proposed: > --- gcc/varasm.cc.jj2024-01-30 08:44:43.304175273 +0100 > +++ gcc/varasm.cc 2024-

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 09:39:12AM -0800, H.J. Lu wrote: > GNU binutils has no issues with it: I know, I meant gcc. If I try the proposed: --- gcc/varasm.cc.jj2024-01-30 08:44:43.304175273 +0100 +++ gcc/varasm.cc 2024-01-31 18:45:57.271087170 +0100 @@ -7459,15 +7459,46 @@ default_elf_sel

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 9:10 AM Jakub Jelinek wrote: > > On Wed, Jan 31, 2024 at 08:48:33AM -0800, H.J. Lu wrote: > > Which function (target hook) can I use to generate > > > > .section.data.rel.ro.local,"awG",@progbits,_ZN1AIxE3fooExx,comdat > > Just > if (decl) > return ge

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Wed, Jan 31, 2024 at 08:48:33AM -0800, H.J. Lu wrote: > Which function (target hook) can I use to generate > > .section.data.rel.ro.local,"awG",@progbits,_ZN1AIxE3fooExx,comdat Just if (decl) return get_section (reloc == 1 ? ".data.rel.ro.loca

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread H.J. Lu
On Wed, Jan 31, 2024 at 8:30 AM Jakub Jelinek wrote: > > On Tue, Jan 30, 2024 at 06:21:36PM -0800, H.J. Lu wrote: > > Changes in v2: > > > > 1. Check decl non-null before dereferencing it. > > 2. Update PR rtl-optimization/113617 from > > Thanks for updating the testcase. > > > --- a/gcc/varasm.cc

Re: [PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-31 Thread Jakub Jelinek
On Tue, Jan 30, 2024 at 06:21:36PM -0800, H.J. Lu wrote: > Changes in v2: > > 1. Check decl non-null before dereferencing it. > 2. Update PR rtl-optimization/113617 from Thanks for updating the testcase. > --- a/gcc/varasm.cc > +++ b/gcc/varasm.cc > @@ -7459,16 +7459,46 @@ default_elf_select_rtx

[PATCH v2] Handle private COMDAT function symbol reference in readonly data section

2024-01-30 Thread H.J. Lu
Changes in v2: 1. Check decl non-null before dereferencing it. 2. Update PR rtl-optimization/113617 from https://gcc.gnu.org/bugzilla/show_bug.cgi?id=113617#c14 --- For a private COMDAT function symbol reference in readonly data section, instead of putting it in .data.rel.ro or .rodata.cst secti