Re: [PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-13 Thread Jakub Jelinek via Gcc-patches
On Fri, May 13, 2022 at 09:53:46PM +0800, Kito Cheng wrote: > LGTM, thanks :) > > On Fri, May 13, 2022 at 4:43 PM Philipp Tomsich > wrote: > > I see you have recently worked on lib/target-support.exp: could you do > > the review of that part? Generally, target specific additions to

Re: [PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-13 Thread Kito Cheng via Gcc-patches
Oh, one minor comment: > +/* { dg-additional-options "-march=rv64gc_zbb" { target { lp64 && > riscv64*-*-* } } } */ { target { rv64 } here > +/* { dg-additional-options "-march=rv32gc_zbb" { target { ilp32 && > riscv64*-*-* } } } */ and { target { rv32 } here That should make riscv32*-*-*

Re: [PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-13 Thread Kito Cheng via Gcc-patches
LGTM, thanks :) On Fri, May 13, 2022 at 4:43 PM Philipp Tomsich wrote: > > +Jakub Jelinek > > Jakub, > > I see you have recently worked on lib/target-support.exp: could you do > the review of that part? > > Thanks, > Philipp. > > On Fri, 13 May 2022 at 00:36, Palmer Dabbelt wrote: > > > > On

Re: [PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-13 Thread Philipp Tomsich
+Jakub Jelinek Jakub, I see you have recently worked on lib/target-support.exp: could you do the review of that part? Thanks, Philipp. On Fri, 13 May 2022 at 00:36, Palmer Dabbelt wrote: > > On Thu, 12 May 2022 11:33:34 PDT (-0700), philipp.toms...@vrull.eu wrote: > > The Zbb support has

Re: [PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-12 Thread Palmer Dabbelt
On Thu, 12 May 2022 11:33:34 PDT (-0700), philipp.toms...@vrull.eu wrote: The Zbb support has introduced ctz and clz to the backend, but some transformations in GCC need to know what the value of c[lt]z at zero is. This affects how the optab is generated and may suppress use of CLZ/CTZ in tree

[PATCH v2] RISC-V: Implement C[LT]Z_DEFINED_VALUE_AT_ZERO

2022-05-12 Thread Philipp Tomsich
The Zbb support has introduced ctz and clz to the backend, but some transformations in GCC need to know what the value of c[lt]z at zero is. This affects how the optab is generated and may suppress use of CLZ/CTZ in tree passes. Among other things, this is needed for the transformation of