Re: [PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-06-14 Thread Philipp Tomsich
Thanks, backport applied to releases/gcc-12! On Tue, 7 Jun 2022 at 12:28, Kito Cheng wrote: > > OK for backport? > > OK, it seems no issue after a week :) > > > > > > On Thu, 2 Jun 2022 at 21:23, Philipp Tomsich > wrote: > > > > > > Thanks, applied to trunk! > > > > > > On Thu, 2 Jun 2022 at 1

Re: [PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-06-07 Thread Kito Cheng via Gcc-patches
> OK for backport? OK, it seems no issue after a week :) > > On Thu, 2 Jun 2022 at 21:23, Philipp Tomsich wrote: > > > > Thanks, applied to trunk! > > > > On Thu, 2 Jun 2022 at 15:17, Kito Cheng wrote: > > > > > > LGTM > > > > > > On Mon, May 30, 2022 at 5:52 AM Philipp Tomsich > > > wrote: >

Re: [PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-06-02 Thread Philipp Tomsich
OK for backport? On Thu, 2 Jun 2022 at 21:23, Philipp Tomsich wrote: > > Thanks, applied to trunk! > > On Thu, 2 Jun 2022 at 15:17, Kito Cheng wrote: > > > > LGTM > > > > On Mon, May 30, 2022 at 5:52 AM Philipp Tomsich > > wrote: > > > > > > The SINGLE_BIT_MASK_OPERAND() is overly restrictive,

Re: [PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-06-02 Thread Philipp Tomsich
Thanks, applied to trunk! On Thu, 2 Jun 2022 at 15:17, Kito Cheng wrote: > > LGTM > > On Mon, May 30, 2022 at 5:52 AM Philipp Tomsich > wrote: > > > > The SINGLE_BIT_MASK_OPERAND() is overly restrictive, triggering for > > bits above 31 only (to side-step any issues with the negative SImode > >

Re: [PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-06-02 Thread Kito Cheng via Gcc-patches
LGTM On Mon, May 30, 2022 at 5:52 AM Philipp Tomsich wrote: > > The SINGLE_BIT_MASK_OPERAND() is overly restrictive, triggering for > bits above 31 only (to side-step any issues with the negative SImode > value 0x8000/(-1ull << 31)/(1 << 31)). This moves the special > handling of this SImode

[PATCH v2] RISC-V: bitmanip: improve constant-loading for (1ULL << 31) in DImode

2022-05-29 Thread Philipp Tomsich
The SINGLE_BIT_MASK_OPERAND() is overly restrictive, triggering for bits above 31 only (to side-step any issues with the negative SImode value 0x8000/(-1ull << 31)/(1 << 31)). This moves the special handling of this SImode value (i.e. the check for (-1ull << 31) to riscv.cc and relaxes the SIN