Re: [PATCH v2] c, c++: Plug -Wduplicated-cond memory leaks [PR99057]

2021-02-10 Thread Jason Merrill via Gcc-patches
On 2/10/21 7:27 PM, Marek Polacek wrote: On Wed, Feb 10, 2021 at 04:48:56PM -0500, Jason Merrill wrote: On 2/10/21 12:35 PM, Marek Polacek wrote: Freeing the condition chain needs to use vec_free which does ->release, or we leak memory. OK, but if chain were an auto_vec, delete would work.

Re: [PATCH v2] c, c++: Plug -Wduplicated-cond memory leaks [PR99057]

2021-02-10 Thread Marek Polacek via Gcc-patches
On Wed, Feb 10, 2021 at 04:48:56PM -0500, Jason Merrill wrote: > On 2/10/21 12:35 PM, Marek Polacek wrote: > > Freeing the condition chain needs to use vec_free which does ->release, > > or we leak memory. > > OK, but if chain were an auto_vec, delete would work. Yes. > Can we merge auto_vec wit