Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-18 Thread Marek Polacek via Gcc-patches
On Tue, May 18, 2021 at 07:35:52PM +0200, Franz Sirl wrote: > Am 2021-05-14 um 00:08 schrieb Marek Polacek via Gcc-patches: > > On Wed, May 12, 2021 at 08:27:18PM -0400, Jason Merrill wrote: > > > On 5/12/21 8:03 PM, Marek Polacek wrote: > > > > diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c > > > >

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-18 Thread Franz Sirl
Am 2021-05-14 um 00:08 schrieb Marek Polacek via Gcc-patches: On Wed, May 12, 2021 at 08:27:18PM -0400, Jason Merrill wrote: On 5/12/21 8:03 PM, Marek Polacek wrote: diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 89f874a32cc..2bcefb619aa 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-13 Thread Jason Merrill via Gcc-patches
On 5/13/21 6:08 PM, Marek Polacek wrote: On Wed, May 12, 2021 at 08:27:18PM -0400, Jason Merrill wrote: On 5/12/21 8:03 PM, Marek Polacek wrote: diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c index 89f874a32cc..2bcefb619aa 100644 --- a/gcc/cp/decl2.c +++ b/gcc/cp/decl2.c @@ -1331,6 +1331,20 @@ an

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-13 Thread Marek Polacek via Gcc-patches
On Wed, May 12, 2021 at 08:27:18PM -0400, Jason Merrill wrote: > On 5/12/21 8:03 PM, Marek Polacek wrote: > > diff --git a/gcc/cp/decl2.c b/gcc/cp/decl2.c > > index 89f874a32cc..2bcefb619aa 100644 > > --- a/gcc/cp/decl2.c > > +++ b/gcc/cp/decl2.c > > @@ -1331,6 +1331,20 @@ any_dependent_type_attrib

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-12 Thread Jason Merrill via Gcc-patches
On 5/12/21 8:03 PM, Marek Polacek wrote: + // FIXME: Add dg error when PR100339 is resolved. + //[[deprecated]] friend void ::foo(int, int); This could be an xfailed dg-error.

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-12 Thread Jason Merrill via Gcc-patches
On 5/12/21 8:03 PM, Marek Polacek wrote: On Wed, May 12, 2021 at 12:21:26PM -0400, Jason Merrill wrote: On 5/12/21 11:03 AM, Marek Polacek wrote: On Wed, May 12, 2021 at 10:37:50AM -0400, Jason Merrill wrote: On 5/11/21 10:45 PM, Marek Polacek wrote: This patch implements [dcl.attr.grammar]/5

Re: [PATCH v2] c++: Check attributes on friend declarations [PR99032]

2021-05-12 Thread Marek Polacek via Gcc-patches
On Wed, May 12, 2021 at 12:21:26PM -0400, Jason Merrill wrote: > On 5/12/21 11:03 AM, Marek Polacek wrote: > > On Wed, May 12, 2021 at 10:37:50AM -0400, Jason Merrill wrote: > > > On 5/11/21 10:45 PM, Marek Polacek wrote: > > > > This patch implements [dcl.attr.grammar]/5: "If an > > > > attribute