Re: [PATCH v2] gcc_update: use human readable name for revision string in gcc/REVISION

2021-07-19 Thread Jakub Jelinek via Gcc-patches
On Mon, Jul 19, 2021 at 11:47:01AM +0100, Iain Sandoe wrote: > > > > On 19 Jul 2021, at 11:39, Richard Biener via Gcc-patches > > wrote: > > > > On Fri, Jul 16, 2021 at 12:37 PM Serge Belyshev > > wrote: > >> > >> Based on discussion I've chosen open-coded version without commit hash. > >

Re: [PATCH v2] gcc_update: use human readable name for revision string in gcc/REVISION

2021-07-19 Thread Iain Sandoe via Gcc-patches
> On 19 Jul 2021, at 11:39, Richard Biener via Gcc-patches > wrote: > > On Fri, Jul 16, 2021 at 12:37 PM Serge Belyshev > wrote: >> >> Based on discussion I've chosen open-coded version without commit hash. > > As said I'd prefer one with (shortened) hash, Likewise, I’ve been using a

Re: [PATCH v2] gcc_update: use human readable name for revision string in gcc/REVISION

2021-07-19 Thread Richard Biener via Gcc-patches
On Fri, Jul 16, 2021 at 12:37 PM Serge Belyshev wrote: > > Based on discussion I've chosen open-coded version without commit hash. As said I'd prefer one with (shortened) hash, but then I'm not angry if people agree on sth else. > >> > > ... Perhaps rename the r, o, rr and m temporaries. > > I

[PATCH v2] gcc_update: use human readable name for revision string in gcc/REVISION

2021-07-16 Thread Serge Belyshev
Based on discussion I've chosen open-coded version without commit hash. >> > > ... Perhaps rename the r, o, rr and m temporaries. I like it better with short names, there is no other code in that script to clash with. (Also, two adjacent case branches for hg and svn are essentialy dead now).