RE: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-11 Thread Bernhard Reutner-Fischer via Gcc-patches
On 11 May 2023 04:30:16 CEST, "Li, Pan2 via Gcc-patches" wrote: >../../gcc/var-tracking.cc:3233:28: error: no match for 'operator!=' (operand >types are 'rtx' {aka 'rtx_def*'} and 'decl_or_value' {aka >'pointer_mux'}). Wouldn't you usually declare operator!= by !(left == right) ? thanks,

RE: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-11 Thread Li, Pan2 via Gcc-patches
...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang ; jeffreya...@gmail.com; ja...@redhat.com; rguent...@suse.de Subject: Re: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value "Li, Pan2" writes: > Thanks Richard Sandiford. Update PATCH v4 here -> > https://gcc.gnu.org/pi

Re: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-10 Thread Richard Sandiford via Gcc-patches
"Li, Pan2" writes: > Thanks Richard Sandiford. Update PATCH v4 here -> > https://gcc.gnu.org/pipermail/gcc-patches/2023-May/618099.html. > >> - if (dv_as_opaque (node->dv) != decl || node->offset != offset) >> + if (node->dv.first_or_null () != decl || node->offset != >> + offset) >

RE: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-10 Thread Li, Pan2 via Gcc-patches
decl_or_value' {aka 'pointer_mux'}). Pan -Original Message- From: Richard Sandiford Sent: Wednesday, May 10, 2023 11:56 PM To: Li, Pan2 Cc: gcc-patches@gcc.gnu.org; juzhe.zh...@rivai.ai; kito.ch...@sifive.com; Wang, Yanzhang ; jeffreya...@gmail.com; ja...@redhat.com; rguent...@su

Re: [PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-10 Thread Richard Sandiford via Gcc-patches
Thanks, mostly looks good to me. Some minor comments below. pan2...@intel.com writes: > From: Pan Li > > The decl_or_value is defined as void * before this PATCH. It will take > care of both the tree_node and rtx_def. Unfortunately, given a void > pointer cannot tell the input is tree_node or

[PATCH v3] Var-Tracking: Typedef pointer_mux as decl_or_value

2023-05-10 Thread Pan Li via Gcc-patches
From: Pan Li The decl_or_value is defined as void * before this PATCH. It will take care of both the tree_node and rtx_def. Unfortunately, given a void pointer cannot tell the input is tree_node or rtx_def. Then we have some implicit structure layout requirement similar as below. Or we will