Re: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Martin Liška
On 7/27/20 12:25 PM, Richard Sandiford wrote: So I don't think there's a different value that parse_and_check_align_values could sensibly insert instead of zero. All right, works for me. Martin

RE: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Hu, Jiangping
> > This patch makes the -falign-foo=0 work as described in the > > documentation. Thanks for all the suggestions, Richard and Segher! > > Hello. > > I'm the author of the original code. > > > > > v3: make change more readable and self-consistent > > v2: at a high level handles -falign-foo=0 lik

Re: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Richard Sandiford
Martin Liška writes: > On 7/27/20 9:46 AM, Hu Jiangping wrote: >> Hi! >> >> This patch makes the -falign-foo=0 work as described in the >> documentation. Thanks for all the suggestions, Richard and Segher! > > Hello. > > I'm the author of the original code. > >> >> v3: make change more readable

Re: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Martin Liška
On 7/27/20 9:46 AM, Hu Jiangping wrote: Hi! This patch makes the -falign-foo=0 work as described in the documentation. Thanks for all the suggestions, Richard and Segher! Hello. I'm the author of the original code. v3: make change more readable and self-consistent v2: at a high level handl

Re: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Richard Sandiford
Hu Jiangping writes: > Hi! > > This patch makes the -falign-foo=0 work as described in the > documentation. Thanks for all the suggestions, Richard and Segher! > > v3: make change more readable and self-consistent > v2: at a high level handles -falign-foo=0 like -falign-foo Thanks, this is OK wit

RE: [PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Hu, Jiangping
Tested on x86_64. > -Original Message- > From: Gcc-patches On Behalf Of Hu > Jiangping > Sent: Monday, July 27, 2020 3:46 PM > To: gcc-patches@gcc.gnu.org; richard.sandif...@arm.com; > seg...@kernel.crashing.org > Subject: [PATCH v3] driver: fix a problem with impl

[PATCH v3] driver: fix a problem with implementation of -falign-foo=0 [PR96247]

2020-07-27 Thread Hu Jiangping
Hi! This patch makes the -falign-foo=0 work as described in the documentation. Thanks for all the suggestions, Richard and Segher! v3: make change more readable and self-consistent v2: at a high level handles -falign-foo=0 like -falign-foo Regards! Hujp --- gcc/opts.c | 24 +++-