Re: [PATCH v3] fixinc: don't "fix" machine names in __has_include(...) [PR91085]

2021-06-29 Thread Xi Ruoyao via Gcc-patches
On Tue, 2021-06-29 at 08:53 -0700, Bruce Korb wrote: > On 6/28/21 10:26 PM, Xi Ruoyao wrote: > > v3: > >    use memmem/memchr instead of trivial loops > >    split most of the logic into a static function > >    avoid hardcoded magic number > >    adjust test > Looks good to me. :) Thanks for

Re: [PATCH v3] fixinc: don't "fix" machine names in __has_include(...) [PR91085]

2021-06-29 Thread Bruce Korb via Gcc-patches
On 6/28/21 10:26 PM, Xi Ruoyao wrote: v3: use memmem/memchr instead of trivial loops split most of the logic into a static function avoid hardcoded magic number adjust test Looks good to me. :)

[PATCH v3] fixinc: don't "fix" machine names in __has_include(...) [PR91085]

2021-06-28 Thread Xi Ruoyao via Gcc-patches
v3: use memmem/memchr instead of trivial loops split most of the logic into a static function avoid hardcoded magic number adjust test fixincludes/ * fixfixes.c (check_has_inc): New static function. (machine_name_fix): Don't replace header names in