Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread H.J. Lu via Gcc-patches
On Tue, Mar 8, 2022 at 7:46 AM Jakub Jelinek wrote: > > On Tue, Mar 08, 2022 at 07:37:17AM -0800, H.J. Lu wrote: > > > Though, perhaps it should be > > > #ifndef __x86_64__ > > > #define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse"))) > > > #endif > > > or something similar, on x86-64

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread Jakub Jelinek via Gcc-patches
On Tue, Mar 08, 2022 at 07:37:17AM -0800, H.J. Lu wrote: > > Though, perhaps it should be > > #ifndef __x86_64__ > > #define LIBGCC2_UNWIND_ATTRIBUTE __attribute__((target ("no-sse"))) > > #endif > > or something similar, on x86-64 one at least normally doesn't use lower > > stack realignment

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread H.J. Lu via Gcc-patches
On Tue, Mar 8, 2022 at 4:29 AM Jakub Jelinek wrote: > > On Tue, Mar 08, 2022 at 12:15:15PM +0100, Jakub Jelinek via Gcc-patches wrote: > > > --- gcc/config/i386/i386.h.jj 2022-02-25 12:06:45.535493490 +0100 > > > +++ gcc/config/i386/i386.h 2022-03-08 11:20:43.207043370 +0100 > > > @@

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread Eric Botcazou via Gcc-patches
> Disabling sse/sse2 might be a problem especially on mingw where we need to > restore SSE registers in the EH return, no? Not in 32-bit mode I think, all XMM registers are call used. -- Eric Botcazou

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread Jakub Jelinek via Gcc-patches
On Tue, Mar 08, 2022 at 12:15:15PM +0100, Jakub Jelinek via Gcc-patches wrote: > > --- gcc/config/i386/i386.h.jj 2022-02-25 12:06:45.535493490 +0100 > > +++ gcc/config/i386/i386.h 2022-03-08 11:20:43.207043370 +0100 > > @@ -2848,6 +2848,10 @@ extern enum attr_cpu ix86_schedule; > > #define

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread Jakub Jelinek via Gcc-patches
On Tue, Mar 08, 2022 at 11:23:51AM +0100, Jakub Jelinek via Gcc-patches wrote: > On Mon, Mar 07, 2022 at 07:06:28AM -0800, H.J. Lu wrote: > > Since eh_return doesn't work with stack realignment, disable SSE on > > unwind-c.c and unwind-dw2.c to avoid stack realignment with the 4-byte > > incoming

Re: [PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-08 Thread Jakub Jelinek via Gcc-patches
On Mon, Mar 07, 2022 at 07:06:28AM -0800, H.J. Lu wrote: > Since eh_return doesn't work with stack realignment, disable SSE on > unwind-c.c and unwind-dw2.c to avoid stack realignment with the 4-byte > incoming stack to avoid SSE usage which is caused by > > commit

[PATCH v3] x86: Disable SSE on unwind-c.c and unwind-dw2.c

2022-03-07 Thread H.J. Lu via Gcc-patches
Since eh_return doesn't work with stack realignment, disable SSE on unwind-c.c and unwind-dw2.c to avoid stack realignment with the 4-byte incoming stack to avoid SSE usage which is caused by commit 609e8c492d62d92465460eae3d43dfc4b2c68288 Author: H.J. Lu Date: Sat Feb 26 14:17:23 2022 -0800