Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-08-19 Thread Sandra Loosemore
On 8/9/24 10:42, Jakub Jelinek wrote: Why needs omp-general.h the move in GTFILES etc.? Will just moving those definitions be ok? I just double-checked that. The Makefile.in change to reorder omp-general.h in GTFILES is because of moving the definition of score_wide_int there from omp-gene

Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-08-09 Thread Jakub Jelinek
On Sat, Jul 20, 2024 at 02:42:20PM -0600, Sandra Loosemore wrote: > +static tree > +omp_encode_kind_arch_isa_props (tree props) > +{ > + if (!props) > +return NULL_TREE; > + size_t length = 1; > + for (tree p = props; p; p = TREE_CHAIN (p)) > +length += strlen (omp_context_name_list_prop

Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-07-25 Thread Sandra Loosemore
On 7/25/24 08:00, Tobias Burnus wrote: Hi Sandra, thanks for your patch. (Disclaimer: I have not finished reading through your patch.) Some upfront generic remarks: [* When first compiling it (incremental build), I did run into the issue that OMP_METADIRECTIVE_CHECK wasn't declared. Thus, t

Re: [PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-07-25 Thread Tobias Burnus
Hi Sandra, thanks for your patch. (Disclaimer: I have not finished reading through your patch.) Some upfront generic remarks: [* When first compiling it (incremental build), I did run into the issue that OMP_METADIRECTIVE_CHECK wasn't declared. Thus, there seems to be a dependency issue cau

[PATCH v3 01/12] OpenMP: metadirective tree data structures and front-end interfaces

2024-07-20 Thread Sandra Loosemore
This patch adds the OMP_METADIRECTIVE tree node and shared tree-level support for manipulating metadirectives. It defines/exposes interfaces that will be used in subsequent patches that add front-end and middle-end support, but nothing generates these nodes yet. This patch also adds compile-time