Re: [PATCH v3 09/10] Ignore LLVM's blank lines.

2019-01-28 Thread H.J. Lu
On Wed, Dec 12, 2018 at 3:55 AM Andrew Stubbs wrote: > > > [Already approved by Jeff Law. Included here for completeness.] > > The GCN toolchain must use the LLVM assembler and linker because there's no > binutils port. The LLVM tools do not have the same diagnostic style as > binutils, so the "b

Re: [PATCH v3 09/10] Ignore LLVM's blank lines.

2018-12-17 Thread Andrew Stubbs
On 12/12/2018 12:07, Rainer Orth wrote: * lib/target-supports.exp (check_effective_target_llvm_binutils): New. like "exceptions", this new effective-target keyword needs documenting in sourcebuild.texi. This patch adds the missing docs, and removes the extra blank lines. OK? Andrew

Re: [PATCH v3 09/10] Ignore LLVM's blank lines.

2018-12-12 Thread Segher Boessenkool
Hi! On Wed, Dec 12, 2018 at 11:52:56AM +, Andrew Stubbs wrote: > > @@ -9032,9 +9040,16 @@ proc check_effective_target_cet { } { > } "-O2" ] > } > > + > # Return 1 if target supports floating point "infinite" > proc check_effective_target_inf { } { Stray newline? Segher

Re: [PATCH v3 09/10] Ignore LLVM's blank lines.

2018-12-12 Thread Rainer Orth
Hi Andrew, > [Already approved by Jeff Law. Included here for completeness.] > > The GCN toolchain must use the LLVM assembler and linker because there's no > binutils port. The LLVM tools do not have the same diagnostic style as > binutils, so the "blank line(s) in output" tests are inappropriat

[PATCH v3 09/10] Ignore LLVM's blank lines.

2018-12-12 Thread Andrew Stubbs
[Already approved by Jeff Law. Included here for completeness.] The GCN toolchain must use the LLVM assembler and linker because there's no binutils port. The LLVM tools do not have the same diagnostic style as binutils, so the "blank line(s) in output" tests are inappropriate (and very noisy).