Re: [PATCH v3 2/2] C++: Support constexpr strings for asm statements

2024-06-12 Thread Jason Merrill
On 6/11/24 23:53, Andi Kleen wrote: Sorry I must have misunderstood you. I thought the patch was already approved earlier and I did commit. I can revert or do additional changes. I only meant to approve the refactoring patch, but no worries. On Tue, Jun 11, 2024 at 04:31:30PM -0400, Jason Me

Re: [PATCH v3 2/2] C++: Support constexpr strings for asm statements

2024-06-11 Thread Xi Ruoyao
On Tue, 2024-06-11 at 20:53 -0700, Andi Kleen wrote: > > > -Some assemblers allow semicolons as a line separator. However, > > > -note that some assembler dialects use semicolons to start a comment. > > > +Some assemblers allow semicolons as a line separator. However, > > > +note that some assemble

Re: [PATCH v3 2/2] C++: Support constexpr strings for asm statements

2024-06-11 Thread Andi Kleen
Hi Jason, Sorry I must have misunderstood you. I thought the patch was already approved earlier and I did commit. I can revert or do additional changes. On Tue, Jun 11, 2024 at 04:31:30PM -0400, Jason Merrill wrote: > > + if (tok->type == CPP_OPEN_PAREN) > > +{ > > + matching_parens p

Re: [PATCH v3 2/2] C++: Support constexpr strings for asm statements

2024-06-11 Thread Jason Merrill
On 6/5/24 00:45, Andi Kleen wrote: Some programing styles use a lot of inline assembler, and it is common to use very complex preprocessor macros to generate the assembler strings for the asm statements. In C++ there would be a typesafe alternative using templates and constexpr to generate the as

[PATCH v3 2/2] C++: Support constexpr strings for asm statements

2024-06-04 Thread Andi Kleen
Some programing styles use a lot of inline assembler, and it is common to use very complex preprocessor macros to generate the assembler strings for the asm statements. In C++ there would be a typesafe alternative using templates and constexpr to generate the assembler strings, but unfortunately th