Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-23 Thread chenglulu
在 2023/11/23 下午8:24, Xi Ruoyao 写道: On Thu, 2023-11-23 at 17:14 +0800, chenglulu wrote: When I look at this code and compare it to our scalar implementation, it seems that our scalar implementation still lacks an "lround". Should be "lroundeven". We don't have an instruction for lround :(.

Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-23 Thread Xi Ruoyao
On Thu, 2023-11-23 at 17:14 +0800, chenglulu wrote: > When I look at this code and compare it to our scalar implementation, it > seems > > that our scalar implementation still lacks an "lround". Should be "lroundeven". We don't have an instruction for lround :(. I tried this but it does not

Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-23 Thread chenglulu
在 2023/11/23 下午4:58, Xi Ruoyao 写道: On Thu, 2023-11-23 at 16:23 +0800, chenglulu wrote: I tested it and it was fine. I never knew this could be used like this. I remember when I wrote r13-3920 I tried this but failed. Maybe something has been improved in machine description parser, or

Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-23 Thread Xi Ruoyao
On Thu, 2023-11-23 at 16:23 +0800, chenglulu wrote: > I tested it and it was fine. I never knew this could be used like > this. I remember when I wrote r13-3920 I tried this but failed. Maybe something has been improved in machine description parser, or perhaps I just did some stupid thing that

Re: [PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-23 Thread chenglulu
I tested it and it was fine. I never knew this could be used like this. Thank you! 在 2023/11/20 上午8:47, Xi Ruoyao 写道: No functional change, just a cleanup. gcc/ChangeLog: * config/loongarch/loongarch.md (lrint_allow_inexact): Remove. (2): Check if == UNSPEC_FTINT

[PATCH v3 4/5] LoongArch: Remove lrint_allow_inexact

2023-11-19 Thread Xi Ruoyao
No functional change, just a cleanup. gcc/ChangeLog: * config/loongarch/loongarch.md (lrint_allow_inexact): Remove. (2): Check if == UNSPEC_FTINT instead of . --- gcc/config/loongarch/loongarch.md | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git