Re: [PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-16 Thread Sebastian Huber
On 16/08/2021 14:33, Martin Liška wrote: On 8/12/21 6:13 PM, Joseph Myers wrote: This is not a review of the patch, but I think this version addresses all the issues I had with previous versions regarding target macro/hook handling. And I'm fine with the GCOV part. Please install the patch.

Re: [PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-16 Thread Martin Liška
On 8/12/21 6:13 PM, Joseph Myers wrote: This is not a review of the patch, but I think this version addresses all the issues I had with previous versions regarding target macro/hook handling. And I'm fine with the GCOV part. Please install the patch. Martin

Re: [PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-12 Thread Joseph Myers
On Thu, 12 Aug 2021, Sebastian Huber wrote: > If -fprofile-update=atomic is used, then the target must provide atomic > operations for the counters of the type returned by get_gcov_type(). > This is a 64-bit type for targets which have a 64-bit long long type. > On 32-bit targets this could be an

Re: [PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-12 Thread Sebastian Huber
On 12/08/2021 13:19, Martin Liška wrote: One small nit, once you sent a new patch version, can you please describe what has changed since the previous one? Yes, sorry. In v4 I changed the target macro to a target hook. Also the TARGET_GCOV_TYPE_SIZE is now redefined in sparc.c using an

Re: [PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-12 Thread Martin Liška
Hello. One small nit, once you sent a new patch version, can you please describe what has changed since the previous one? Cheers, Martin

[PATCH v4] gcov: Add TARGET_GCOV_TYPE_SIZE target hook

2021-08-12 Thread Sebastian Huber
If -fprofile-update=atomic is used, then the target must provide atomic operations for the counters of the type returned by get_gcov_type(). This is a 64-bit type for targets which have a 64-bit long long type. On 32-bit targets this could be an issue since they may not provide 64-bit atomic